From 7562959e441466a0cea755b2c6607edb64439073 Mon Sep 17 00:00:00 2001 From: Huan Wang Date: Sat, 12 Oct 2019 00:48:22 -0600 Subject: [PATCH] toolkit linter line number off by one (#19782) it is actually an intended feature by tslint: https://github.com/palantir/tslint/issues/4528 So adding 1 to the line number here in the plugin --- packages/grafana-toolkit/src/cli/tasks/plugin.build.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/grafana-toolkit/src/cli/tasks/plugin.build.ts b/packages/grafana-toolkit/src/cli/tasks/plugin.build.ts index eed299d56f0..55586ae2d9b 100644 --- a/packages/grafana-toolkit/src/cli/tasks/plugin.build.ts +++ b/packages/grafana-toolkit/src/cli/tasks/plugin.build.ts @@ -152,9 +152,11 @@ export const lintPlugin = useSpinner('Linting', async ({ fix }) => { failures.forEach(f => { // tslint:disable-next-line console.log( - `${f.getRuleSeverity() === 'warning' ? 'WARNING' : 'ERROR'}: ${f.getFileName().split('src')[1]}[${ - f.getStartPosition().getLineAndCharacter().line - }:${f.getStartPosition().getLineAndCharacter().character}]: ${f.getFailure()}` + `${f.getRuleSeverity() === 'warning' ? 'WARNING' : 'ERROR'}: ${ + f.getFileName().split('src')[1] + }[${f.getStartPosition().getLineAndCharacter().line + 1}:${ + f.getStartPosition().getLineAndCharacter().character + }]: ${f.getFailure()}` ); }); console.log('\n');