From 7573fc4152e5a0f9b80fd458062ec4ca9fbb6174 Mon Sep 17 00:00:00 2001 From: "grafana-delivery-bot[bot]" <132647405+grafana-delivery-bot[bot]@users.noreply.github.com> Date: Tue, 17 Sep 2024 16:23:02 +0300 Subject: [PATCH] [v11.2.x] LibraryPanels: Fix folderUid nil pointer dereference (#93401) LibraryPanels: Fix folderUid nil pointer dereference (#93400) (cherry picked from commit cbf2aa993e1b96b805ecad3dc9541d29d368ba2a) Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com> --- pkg/services/libraryelements/database.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/services/libraryelements/database.go b/pkg/services/libraryelements/database.go index 5bb08c3281a..123ace40c28 100644 --- a/pkg/services/libraryelements/database.go +++ b/pkg/services/libraryelements/database.go @@ -145,7 +145,7 @@ func (l *LibraryElementService) createLibraryElement(c context.Context, signedIn metrics.MFolderIDsServiceCount.WithLabelValues(metrics.LibraryElements).Inc() // folderUID *string will be changed to string - var folderUID string + var folderUID = "" if cmd.FolderUID != nil { folderUID = *cmd.FolderUID } @@ -172,9 +172,9 @@ func (l *LibraryElementService) createLibraryElement(c context.Context, signedIn err = l.SQLStore.WithTransactionalDbSession(c, func(session *db.Session) error { if l.features.IsEnabled(c, featuremgmt.FlagLibraryPanelRBAC) { - allowed, err := l.AccessControl.Evaluate(c, signedInUser, ac.EvalPermission(ActionLibraryPanelsCreate, dashboards.ScopeFoldersProvider.GetResourceScopeUID(*cmd.FolderUID))) + allowed, err := l.AccessControl.Evaluate(c, signedInUser, ac.EvalPermission(ActionLibraryPanelsCreate, dashboards.ScopeFoldersProvider.GetResourceScopeUID(folderUID))) if !allowed { - return fmt.Errorf("insufficient permissions for creating library panel in folder with UID %s", *cmd.FolderUID) + return fmt.Errorf("insufficient permissions for creating library panel in folder with UID %s", folderUID) } if err != nil { return err