From 7612f3d95569ac2e6bb56b954f418eec0d9e98b8 Mon Sep 17 00:00:00 2001 From: Joey <90795735+joey-grafana@users.noreply.github.com> Date: Tue, 1 Aug 2023 08:44:13 +0100 Subject: [PATCH] Tempo: If no search tag then do not query API for tag values (#72522) * If no tag then do not query api for tag values * Update test --- .../datasource/tempo/SearchTraceQLEditor/SearchField.test.tsx | 2 +- .../datasource/tempo/SearchTraceQLEditor/SearchField.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/public/app/plugins/datasource/tempo/SearchTraceQLEditor/SearchField.test.tsx b/public/app/plugins/datasource/tempo/SearchTraceQLEditor/SearchField.test.tsx index 924414b8145..075f5240b78 100644 --- a/public/app/plugins/datasource/tempo/SearchTraceQLEditor/SearchField.test.tsx +++ b/public/app/plugins/datasource/tempo/SearchTraceQLEditor/SearchField.test.tsx @@ -128,7 +128,7 @@ describe('SearchField', () => { }; const { container } = renderSearchField(updateFilter, filter, ['tag1', 'tag22', 'tag33']); - const select = await container.querySelector(`input[aria-label="select test1 tag"]`); + const select = container.querySelector(`input[aria-label="select test1 tag"]`); expect(select).not.toBeNull(); expect(select).toBeInTheDocument(); if (select) { diff --git a/public/app/plugins/datasource/tempo/SearchTraceQLEditor/SearchField.tsx b/public/app/plugins/datasource/tempo/SearchTraceQLEditor/SearchField.tsx index 2c7c119ffec..e705524dd94 100644 --- a/public/app/plugins/datasource/tempo/SearchTraceQLEditor/SearchField.tsx +++ b/public/app/plugins/datasource/tempo/SearchTraceQLEditor/SearchField.tsx @@ -60,7 +60,7 @@ const SearchField = ({ const updateOptions = async () => { try { - return await languageProvider.getOptionsV2(scopedTag); + return filter.tag ? await languageProvider.getOptionsV2(scopedTag) : []; } catch (error) { // Display message if Tempo is connected but search 404's if (isFetchError(error) && error?.status === 404) {