Plugins: Unexport PluginDir field from PluginDTO (#59190)

* unexport pluginDir from dto * more err checks * tidy * fix tests * fix dboard file tests * fix import * fix tests * apply PR feedback * combine interfaces * fix logs and clean up test * filepath clean * use fs.File * rm explicit type
2022-12-02 13:46:55 +01:00
parent 6d1bcd9f40
commit 76233f9997
15 changed files with 223 additions and 286 deletions
@@ -81,8 +81,7 @@ func TestPluginManager_Add_Remove(t *testing.T) {

 			err = inst.Add(context.Background(), pluginID, v1, plugins.CompatOpts{})
 			require.Equal(t, plugins.DuplicateError{
-				PluginID:          pluginV1.ID,
-				ExistingPluginDir: pluginV1.PluginDir,
+				PluginID: pluginV1.ID,
 			}, err)
 		})