From 763e958d9dd51402936c66d56f6afce727c18945 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torkel=20=C3=96degaard?= Date: Tue, 24 Nov 2020 07:27:08 +0100 Subject: [PATCH] Login: Fixes redirect url encoding issues of # %23 being unencoded after login (#29299) --- pkg/api/login.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/api/login.go b/pkg/api/login.go index d4f9ebaa3b9..511b0007ced 100644 --- a/pkg/api/login.go +++ b/pkg/api/login.go @@ -121,7 +121,7 @@ func (hs *HTTPServer) LoginView(c *models.ReqContext) { } } - if redirectTo, _ := url.QueryUnescape(c.GetCookie("redirect_to")); len(redirectTo) > 0 { + if redirectTo := c.GetCookie("redirect_to"); len(redirectTo) > 0 { if err := hs.ValidateRedirectTo(redirectTo); err != nil { // the user is already logged so instead of rendering the login page with error // it should be redirected to the home page. @@ -229,7 +229,7 @@ func (hs *HTTPServer) LoginPost(c *models.ReqContext, cmd dtos.LoginCommand) Res "message": "Logged in", } - if redirectTo, _ := url.QueryUnescape(c.GetCookie("redirect_to")); len(redirectTo) > 0 { + if redirectTo := c.GetCookie("redirect_to"); len(redirectTo) > 0 { if err := hs.ValidateRedirectTo(redirectTo); err == nil { result["redirectUrl"] = redirectTo } else {