Chore: Refactor alerting notifier tests to remove goconvey (#40758)

pkg/services/alerting/notifiers/dingding_test.go

@@ -9,51 +9,50 @@ import (
 	"github.com/grafana/grafana/pkg/services/alerting"
 	"github.com/grafana/grafana/pkg/services/encryption/ossencryption"
 	"github.com/grafana/grafana/pkg/services/validations"
-	. "github.com/smartystreets/goconvey/convey"
+
+	"github.com/stretchr/testify/require"
 )
 
 func TestDingDingNotifier(t *testing.T) {
-	Convey("Dingding notifier tests", t, func() {
-		Convey("empty settings should return error", func() {
-			json := `{ }`
+	t.Run("empty settings should return error", func(t *testing.T) {
+		json := `{ }`
 
-			settingsJSON, _ := simplejson.NewJson([]byte(json))
-			model := &models.AlertNotification{
-				Name:     "dingding_testing",
-				Type:     "dingding",
-				Settings: settingsJSON,
-			}
+		settingsJSON, _ := simplejson.NewJson([]byte(json))
+		model := &models.AlertNotification{
+			Name:     "dingding_testing",
+			Type:     "dingding",
+			Settings: settingsJSON,
+		}
 
-			_, err := newDingDingNotifier(model, ossencryption.ProvideService().GetDecryptedValue)
-			So(err, ShouldNotBeNil)
-		})
-		Convey("settings should trigger incident", func() {
-			json := `{ "url": "https://www.google.com" }`
+		_, err := newDingDingNotifier(model, ossencryption.ProvideService().GetDecryptedValue)
+		require.Error(t, err)
+	})
+	t.Run("settings should trigger incident", func(t *testing.T) {
+		json := `{ "url": "https://www.google.com" }`
 
-			settingsJSON, _ := simplejson.NewJson([]byte(json))
-			model := &models.AlertNotification{
-				Name:     "dingding_testing",
-				Type:     "dingding",
-				Settings: settingsJSON,
-			}
+		settingsJSON, _ := simplejson.NewJson([]byte(json))
+		model := &models.AlertNotification{
+			Name:     "dingding_testing",
+			Type:     "dingding",
+			Settings: settingsJSON,
+		}
 
-			not, err := newDingDingNotifier(model, ossencryption.ProvideService().GetDecryptedValue)
-			notifier := not.(*DingDingNotifier)
+		not, err := newDingDingNotifier(model, ossencryption.ProvideService().GetDecryptedValue)
+		notifier := not.(*DingDingNotifier)
 
-			So(err, ShouldBeNil)
-			So(notifier.Name, ShouldEqual, "dingding_testing")
-			So(notifier.Type, ShouldEqual, "dingding")
-			So(notifier.URL, ShouldEqual, "https://www.google.com")
+		require.Nil(t, err)
+		require.Equal(t, "dingding_testing", notifier.Name)
+		require.Equal(t, "dingding", notifier.Type)
+		require.Equal(t, "https://www.google.com", notifier.URL)
 
-			Convey("genBody should not panic", func() {
-				evalContext := alerting.NewEvalContext(context.Background(),
-					&alerting.Rule{
-						State:   models.AlertStateAlerting,
-						Message: `{host="localhost"}`,
-					}, &validations.OSSPluginRequestValidator{})
-				_, err = notifier.genBody(evalContext, "")
-				So(err, ShouldBeNil)
-			})
+		t.Run("genBody should not panic", func(t *testing.T) {
+			evalContext := alerting.NewEvalContext(context.Background(),
+				&alerting.Rule{
+					State:   models.AlertStateAlerting,
+					Message: `{host="localhost"}`,
+				}, &validations.OSSPluginRequestValidator{})
+			_, err = notifier.genBody(evalContext, "")
+			require.Nil(t, err)
 		})
 	})
 }