From 774ad3ff3938fae62f5a413cf37507f9281bc011 Mon Sep 17 00:00:00 2001 From: Mario Trangoni Date: Tue, 13 Nov 2018 21:20:44 +0100 Subject: [PATCH] pkg/cmd/grafana-server/server.go: Check sendSystemdNotification return value. See, $ gometalinter --vendor --deadline 10m --disable-all --enable=errcheck ./... server.go:165:25:warning: error return value not checked (sendSystemdNotification("READY=1")) (errcheck) --- pkg/cmd/grafana-server/server.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/cmd/grafana-server/server.go b/pkg/cmd/grafana-server/server.go index 6a0c87bb0e8..9e83f1036bb 100644 --- a/pkg/cmd/grafana-server/server.go +++ b/pkg/cmd/grafana-server/server.go @@ -162,7 +162,11 @@ func (g *GrafanaServerImpl) Run() error { }) } - sendSystemdNotification("READY=1") + err = sendSystemdNotification("READY=1") + if err != nil { + return fmt.Errorf("Could not send systemd notification: %v", err) + } + return g.childRoutines.Wait() }