From 77fd5729731a4ce3881801628440a964da5bc12f Mon Sep 17 00:00:00 2001 From: Will Assis <35489495+gassiss@users.noreply.github.com> Date: Fri, 14 Feb 2025 15:39:51 -0300 Subject: [PATCH] dont return not found error in mode 2 (#100758) * dual writer: dont return not found error in mode 2 when failing to find object in unistore --- pkg/apiserver/rest/dualwriter_mode2.go | 2 +- pkg/apiserver/rest/dualwriter_mode2_test.go | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/apiserver/rest/dualwriter_mode2.go b/pkg/apiserver/rest/dualwriter_mode2.go index 62b3526d504..84e841270e5 100644 --- a/pkg/apiserver/rest/dualwriter_mode2.go +++ b/pkg/apiserver/rest/dualwriter_mode2.go @@ -137,7 +137,7 @@ func (d *DualWriterMode2) Get(ctx context.Context, name string, options *metav1. } }() - return objLegacy, err + return objLegacy, nil } // List overrides the behavior of the generic DualWriter. diff --git a/pkg/apiserver/rest/dualwriter_mode2_test.go b/pkg/apiserver/rest/dualwriter_mode2_test.go index 6e67ac0fe59..dfd7b6db0f5 100644 --- a/pkg/apiserver/rest/dualwriter_mode2_test.go +++ b/pkg/apiserver/rest/dualwriter_mode2_test.go @@ -122,7 +122,6 @@ func TestMode2_Get(t *testing.T) { m.On("Get", mock.Anything, input, mock.Anything).Return(nil, apierrors.NewNotFound( schema.GroupResource{Group: "", Resource: "pods"}, "not-found")) }, - wantErr: true, }, { name: "should return an error when getting an object from both the LegacyStorage and Storage fails",