[9.4.x] Users: Fix org user always getting org id = 1 (#63759)
Users: Fix org user always getting org id = 1 on auto assign false (#63708)
* fix org user always getting org id = 1 on auto assign false
* make tests explicit
* use correct cfg in service accounts
* fix api tests
* fix database test of ac
* fix InsertOrgUser returning affected rows as orgID
(cherry picked from commit c8db771939)
This commit is contained in:
@@ -262,6 +262,7 @@ func createUsersAndTeams(t *testing.T, svcs helperServices, orgID int64, users [
|
||||
IsAdmin: users[i].isAdmin,
|
||||
})
|
||||
require.NoError(t, err)
|
||||
require.Equal(t, orgID, user.OrgID)
|
||||
|
||||
// User is not member of the org
|
||||
if users[i].orgRole == "" {
|
||||
@@ -291,11 +292,19 @@ func createUsersAndTeams(t *testing.T, svcs helperServices, orgID int64, users [
|
||||
|
||||
func setupTestEnv(t testing.TB) (*AccessControlStore, rs.Store, user.Service, team.Service, org.Service) {
|
||||
sql, cfg := db.InitTestDBwithCfg(t)
|
||||
cfg.AutoAssignOrg = true
|
||||
cfg.AutoAssignOrgRole = "Viewer"
|
||||
cfg.AutoAssignOrgId = 1
|
||||
acstore := ProvideService(sql)
|
||||
permissionStore := rs.NewStore(sql)
|
||||
teamService := teamimpl.ProvideService(sql, cfg)
|
||||
orgService, err := orgimpl.ProvideService(sql, cfg, quotatest.New(false, nil))
|
||||
require.NoError(t, err)
|
||||
|
||||
orgID, err := orgService.GetOrCreate(context.Background(), "test")
|
||||
require.Equal(t, int64(1), orgID)
|
||||
require.NoError(t, err)
|
||||
|
||||
userService, err := userimpl.ProvideService(sql, orgService, cfg, teamService, localcache.ProvideService(), quotatest.New(false, nil))
|
||||
require.NoError(t, err)
|
||||
return acstore, permissionStore, userService, teamService, orgService
|
||||
|
||||
Reference in New Issue
Block a user