From 7a7b529e818b9b4a69b9bd4f25695eb5a59f517d Mon Sep 17 00:00:00 2001 From: Kristina Durivage Date: Tue, 25 Nov 2025 14:26:30 -0600 Subject: [PATCH] WIP --- .../correlations/CorrelationsPageWrapper.tsx | 27 +++++++------------ .../features/correlations/useCorrelations.ts | 2 +- .../correlations/useCorrelationsK8s.ts | 5 ++-- 3 files changed, 13 insertions(+), 21 deletions(-) diff --git a/public/app/features/correlations/CorrelationsPageWrapper.tsx b/public/app/features/correlations/CorrelationsPageWrapper.tsx index 5f27f49009a..d6e9dbf8422 100644 --- a/public/app/features/correlations/CorrelationsPageWrapper.tsx +++ b/public/app/features/correlations/CorrelationsPageWrapper.tsx @@ -1,7 +1,4 @@ -import { - generatedAPI as correlationAPIv0alpha1, - CorrelationList, -} from '@grafana/api-clients/rtkq/correlations/v0alpha1'; +import { CorrelationList, useListCorrelationQuery } from '@grafana/api-clients/rtkq/correlations/v0alpha1'; import { config, CorrelationsData } from '@grafana/runtime'; import CorrelationsPage from './CorrelationsPage'; @@ -10,11 +7,10 @@ import { useCorrelations } from './useCorrelations'; import { toEnrichedCorrelationDataK8s } from './useCorrelationsK8s'; export default function CorrelationsPageWrapper() { - //const { remove, get } = useCorrelations(); - try { - const { data, isLoading, error } = correlationAPIv0alpha1.endpoints.listCorrelation.useQuery({}); - - //if (config.featureToggles.kubernetesCorrelations) { + // I cannot use these conditionally, is this okay? + const { remove, get } = useCorrelations(); + const { currentData, isLoading, error } = useListCorrelationQuery({ limit: 10 }); + if (config.featureToggles.kubernetesCorrelations) { const enrichedCorrelations = (correlations?: CorrelationList) => { return correlations !== undefined ? correlations.items.map((item) => toEnrichedCorrelationDataK8s(item)).filter((i) => i !== undefined) @@ -23,15 +19,14 @@ export default function CorrelationsPageWrapper() { // we cant do a straight refetch, we have to pass in new pages if necessary const enhRefetch = (params: GetCorrelationsParams): Promise => { - const { data } = correlationAPIv0alpha1.endpoints.listCorrelation.useQuery({}); - return new Promise(() => enrichedCorrelations(data)); + return new Promise(() => enrichedCorrelations(currentData)); }; return ( ); - } catch (e) { - console.log(e); - } - - /*} else { + } else { return ( ); - }*/ + } } diff --git a/public/app/features/correlations/useCorrelations.ts b/public/app/features/correlations/useCorrelations.ts index 2afbd3227cb..e725a072818 100644 --- a/public/app/features/correlations/useCorrelations.ts +++ b/public/app/features/correlations/useCorrelations.ts @@ -95,7 +95,7 @@ export const useCorrelations = () => { return lastValueFrom( backend.fetch({ url: '/api/datasources/correlations', - params: { page: params.page }, + params: { page: params.page, limit: 10 }, // todo this is to force pagination for testing, remove method: 'GET', showErrorAlert: false, }) diff --git a/public/app/features/correlations/useCorrelationsK8s.ts b/public/app/features/correlations/useCorrelationsK8s.ts index 081b77029b8..9b6e10c63a8 100644 --- a/public/app/features/correlations/useCorrelationsK8s.ts +++ b/public/app/features/correlations/useCorrelationsK8s.ts @@ -1,6 +1,6 @@ import { - generatedAPI as correlationAPIv0alpha1, Correlation as CorrelationK8s, + useListCorrelationQuery, } from '@grafana/api-clients/rtkq/correlations/v0alpha1'; import { CorrelationData, CorrelationExternal, CorrelationQuery } from '@grafana/runtime'; @@ -61,7 +61,8 @@ export const toEnrichedCorrelationDataK8s = (item: CorrelationK8s): CorrelationD }; export const useCorrelationsK8s = () => { - const { data, isLoading, error } = correlationAPIv0alpha1.endpoints.listCorrelation.useQuery({}); + //const { data, isLoading, error } = correlationAPIv0alpha1.endpoints.listCorrelation.useQuery({ limit: 10 }); + const { data, isLoading, error } = useListCorrelationQuery({ limit: 10 }); const enrichedCorrelations = data !== undefined ? data.items.map((item) => toEnrichedCorrelationDataK8s(item)).filter((i) => i !== undefined)