From 7aa06225587ca2f18c678774fef2297c205105f6 Mon Sep 17 00:00:00 2001 From: Georges Chaudy Date: Tue, 9 Sep 2025 14:11:16 +0200 Subject: [PATCH] dashboard: editors can EDIT instead of admin. (#110650) revert editor can admin --- pkg/services/dashboards/service/dashboard_service.go | 2 +- pkg/services/dashboards/service/dashboard_service_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/services/dashboards/service/dashboard_service.go b/pkg/services/dashboards/service/dashboard_service.go index 0b669732eac..04564f3b1bd 100644 --- a/pkg/services/dashboards/service/dashboard_service.go +++ b/pkg/services/dashboards/service/dashboard_service.go @@ -1175,7 +1175,7 @@ func (dr *DashboardServiceImpl) SetDefaultPermissionsAfterCreate(ctx context.Con return nil } permissions = append(permissions, []accesscontrol.SetResourcePermissionCommand{ - {BuiltinRole: string(org.RoleEditor), Permission: dashboardaccess.PERMISSION_ADMIN.String()}, + {BuiltinRole: string(org.RoleEditor), Permission: dashboardaccess.PERMISSION_EDIT.String()}, {BuiltinRole: string(org.RoleViewer), Permission: dashboardaccess.PERMISSION_VIEW.String()}, }...) } diff --git a/pkg/services/dashboards/service/dashboard_service_test.go b/pkg/services/dashboards/service/dashboard_service_test.go index d3b6d33d0aa..e0053b5e40e 100644 --- a/pkg/services/dashboards/service/dashboard_service_test.go +++ b/pkg/services/dashboards/service/dashboard_service_test.go @@ -2118,7 +2118,7 @@ func TestSetDefaultPermissionsAfterCreate(t *testing.T) { featureKubernetesDashboards: true, expectedPermission: []accesscontrol.SetResourcePermissionCommand{ {UserID: 1, Permission: dashboardaccess.PERMISSION_ADMIN.String()}, - {BuiltinRole: string(org.RoleEditor), Permission: dashboardaccess.PERMISSION_ADMIN.String()}, + {BuiltinRole: string(org.RoleEditor), Permission: dashboardaccess.PERMISSION_EDIT.String()}, {BuiltinRole: string(org.RoleViewer), Permission: dashboardaccess.PERMISSION_VIEW.String()}, }, },