From 7bbfb57dd1df61e8449715f3b68dd042e0d7dfa1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Bedi?= Date: Tue, 14 Jul 2020 10:26:25 +0200 Subject: [PATCH] PluginsListPage: More plugins button should open in new window (#26305) Fixes #24622 --- public/app/features/plugins/PluginListPage.tsx | 2 +- .../plugins/__snapshots__/PluginListPage.test.tsx.snap | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/public/app/features/plugins/PluginListPage.tsx b/public/app/features/plugins/PluginListPage.tsx index bafc55fd395..b39e4de5979 100644 --- a/public/app/features/plugins/PluginListPage.tsx +++ b/public/app/features/plugins/PluginListPage.tsx @@ -35,7 +35,6 @@ export class PluginListPage extends PureComponent { const linkButton = { href: 'https://grafana.com/plugins?utm_source=grafana_plugin_list', title: 'Find more plugins on Grafana.com', - target: '_blank', }; return ( @@ -46,6 +45,7 @@ export class PluginListPage extends PureComponent { searchQuery={searchQuery} setSearchQuery={query => setPluginsSearchQuery(query)} linkButton={linkButton} + target="_blank" /> {hasFetched && plugins && plugins && } diff --git a/public/app/features/plugins/__snapshots__/PluginListPage.test.tsx.snap b/public/app/features/plugins/__snapshots__/PluginListPage.test.tsx.snap index 69b2c12edbf..2c92f129b93 100644 --- a/public/app/features/plugins/__snapshots__/PluginListPage.test.tsx.snap +++ b/public/app/features/plugins/__snapshots__/PluginListPage.test.tsx.snap @@ -20,12 +20,12 @@ exports[`Render should render component 1`] = ` linkButton={ Object { "href": "https://grafana.com/plugins?utm_source=grafana_plugin_list", - "target": "_blank", "title": "Find more plugins on Grafana.com", } } searchQuery="" setSearchQuery={[Function]} + target="_blank" /> @@ -51,12 +51,12 @@ exports[`Render should render list 1`] = ` linkButton={ Object { "href": "https://grafana.com/plugins?utm_source=grafana_plugin_list", - "target": "_blank", "title": "Find more plugins on Grafana.com", } } searchQuery="" setSearchQuery={[Function]} + target="_blank" />