Background Services: Add wrapper to support startup order (#110225)

This commit is contained in:
Todd Treece
2025-09-10 09:06:25 +01:00
committed by GitHub
parent 60d26ac0ce
commit 7c242eeaef
17 changed files with 790 additions and 36 deletions
+1 -3
View File
@@ -36,7 +36,6 @@ import (
"github.com/grafana/grafana/pkg/infra/tracing"
"github.com/grafana/grafana/pkg/middleware"
"github.com/grafana/grafana/pkg/modules"
servicetracing "github.com/grafana/grafana/pkg/modules/tracing"
"github.com/grafana/grafana/pkg/plugins"
"github.com/grafana/grafana/pkg/registry"
"github.com/grafana/grafana/pkg/registry/apis/datasource"
@@ -172,8 +171,7 @@ func ProvideService(
dualWriterMetrics: grafanarest.NewDualWriterMetrics(reg),
}
// This will be used when running as a dskit service
service := services.NewBasicService(s.start, s.running, nil).WithName(modules.GrafanaAPIServer)
s.NamedService = servicetracing.NewServiceTracer(tracing.GetTracerProvider(), service)
s.NamedService = services.NewBasicService(s.start, s.running, nil).WithName(modules.GrafanaAPIServer)
// TODO: this is very hacky
// We need to register the routes in ProvideService to make sure
+10
View File
@@ -1983,6 +1983,16 @@ var (
Owner: grafanaPartnerPluginsSquad,
Expression: "false",
},
{
Name: "dskitBackgroundServices",
Description: "Enables dskit background service wrapper",
HideFromAdminPage: true,
HideFromDocs: true,
Stage: FeatureStageExperimental,
RequiresRestart: true,
Owner: grafanaPluginsPlatformSquad,
Expression: "false",
},
}
)
+1
View File
@@ -254,3 +254,4 @@ alertingTriage,experimental,@grafana/alerting-squad,false,false,true
graphiteBackendMode,privatePreview,@grafana/partner-datasources,false,false,false
azureResourcePickerUpdates,preview,@grafana/partner-datasources,false,false,true
prometheusTypeMigration,experimental,@grafana/partner-datasources,false,true,false
dskitBackgroundServices,experimental,@grafana/plugins-platform-backend,false,true,false
1 Name Stage Owner requiresDevMode RequiresRestart FrontendOnly
254 graphiteBackendMode privatePreview @grafana/partner-datasources false false false
255 azureResourcePickerUpdates preview @grafana/partner-datasources false false true
256 prometheusTypeMigration experimental @grafana/partner-datasources false true false
257 dskitBackgroundServices experimental @grafana/plugins-platform-backend false true false
+4
View File
@@ -1026,4 +1026,8 @@ const (
// FlagPrometheusTypeMigration
// Checks for deprecated Prometheus authentication methods (SigV4 and Azure), installs the relevant data source, and migrates the Prometheus data sources
FlagPrometheusTypeMigration = "prometheusTypeMigration"
// FlagDskitBackgroundServices
// Enables dskit background service wrapper
FlagDskitBackgroundServices = "dskitBackgroundServices"
)
+19
View File
@@ -1169,6 +1169,25 @@
"codeowner": "@grafana/observability-metrics"
}
},
{
"metadata": {
"name": "dskitBackgroundServices",
"resourceVersion": "1757339637779",
"creationTimestamp": "2025-09-03T12:20:24Z",
"annotations": {
"grafana.app/updatedTimestamp": "2025-09-08 13:53:57.77994 +0000 UTC"
}
},
"spec": {
"description": "Enables dskit background service wrapper",
"stage": "experimental",
"codeowner": "@grafana/plugins-platform-backend",
"requiresRestart": true,
"hideFromAdminPage": true,
"hideFromDocs": true,
"expression": "false"
}
},
{
"metadata": {
"name": "editPanelCSVDragAndDrop",