From 7d8fbe645d26fdc0678575814f68fbd3d8dd4a70 Mon Sep 17 00:00:00 2001 From: Clarity-89 Date: Mon, 17 Feb 2025 08:43:12 +0200 Subject: [PATCH] Update preview banner copy --- .../provisioned/DashboardPreviewBanner.tsx | 23 +++++++++++++++---- .../saving/provisioned/defaults.ts | 2 +- 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/public/app/features/dashboard-scene/saving/provisioned/DashboardPreviewBanner.tsx b/public/app/features/dashboard-scene/saving/provisioned/DashboardPreviewBanner.tsx index 8e16828000d..54dcdf61445 100644 --- a/public/app/features/dashboard-scene/saving/provisioned/DashboardPreviewBanner.tsx +++ b/public/app/features/dashboard-scene/saving/provisioned/DashboardPreviewBanner.tsx @@ -10,15 +10,16 @@ interface DashboardPreviewBannerProps { export function DashboardPreviewBanner({ queryParams, route, path }: DashboardPreviewBannerProps) { const hasPrLink = Boolean(queryParams.prLink); - const isProvisioned = route === DashboardRoutes.Provisioning && path; + const isProvisioned = Boolean(route === DashboardRoutes.Provisioning && path); if ('kiosk' in queryParams || (!queryParams.isPreview && !isProvisioned)) { return null; } + const title = getTitle({ isProvisioned, hasPR: hasPrLink }); return ( The value is not saved in the grafana database. - ) : ( - queryParams.prLink && <>Branch successfully created. - )} + ) : null} ); } + +type Opts = { + isProvisioned?: boolean; + hasPR: boolean; +}; +function getTitle({ isProvisioned, hasPR }: Opts) { + if (isProvisioned) { + return 'This dashboard is loaded from an external repository'; + } + if (hasPR) { + return "This dashboard is a draft. The changes aren't live yet. You can review them in GitHub."; + } + return 'This dashboard is a draft. The changes aren’t live yet. Submit a pull request for review.'; +} diff --git a/public/app/features/dashboard-scene/saving/provisioned/defaults.ts b/public/app/features/dashboard-scene/saving/provisioned/defaults.ts index 6f9247a480a..877183fcda9 100644 --- a/public/app/features/dashboard-scene/saving/provisioned/defaults.ts +++ b/public/app/features/dashboard-scene/saving/provisioned/defaults.ts @@ -12,7 +12,7 @@ export function getWorkflowOptions(config?: RepositorySpec) { const availableOptions: Array<{ label: string; value: WorkflowOption }> = [ { label: `Push to ${config.github?.branch}`, value: 'push' }, - { label: 'Push to Different Branch', value: 'branch' }, + { label: 'Push to different branch', value: 'branch' }, ]; // Filter options based on the workflows in the config