From 7e13d0f773a5be6362d8ef28e578a0e5a365392f Mon Sep 17 00:00:00 2001 From: Johannes Schill Date: Tue, 16 Jan 2018 09:45:22 +0100 Subject: [PATCH] dashfolders: Always get dashboardid and backendsrv from props #10275 --- .../app/core/components/Permissions/Permissions.tsx | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/public/app/core/components/Permissions/Permissions.tsx b/public/app/core/components/Permissions/Permissions.tsx index 86be2bddbaf..a01cf8d4e2e 100644 --- a/public/app/core/components/Permissions/Permissions.tsx +++ b/public/app/core/components/Permissions/Permissions.tsx @@ -53,7 +53,6 @@ class PermissionsInner extends Component { items: DashboardAcl[]; dummyItems: DashboardAcl[]; permissionOptions = [{ value: 1, text: 'View' }, { value: 2, text: 'Edit' }, { value: 4, text: 'Admin' }]; - backendSrv: any; aclTypes = [ { value: 'Group', text: 'Team' }, { value: 'User', text: 'User' }, @@ -69,15 +68,13 @@ class PermissionsInner extends Component { constructor(props) { super(props); - const { dashboardId, backendSrv, permissions } = this.props; + const { dashboardId, permissions } = this.props; - this.dashboardId = dashboardId; - this.backendSrv = backendSrv; this.permissionChanged = this.permissionChanged.bind(this); this.typeChanged = this.typeChanged.bind(this); this.removeItem = this.removeItem.bind(this); this.update = this.update.bind(this); - permissions.load(this.dashboardId); + permissions.load(dashboardId); this.state = { newType: 'Group', @@ -119,10 +116,10 @@ class PermissionsInner extends Component { typeChanged(evt) { const { value } = evt.target; - const { permissions } = this.props; + const { permissions, dashboardId } = this.props; if (value === 'Viewer' || value === 'Editor') { - permissions.addStoreItem({ permission: 1, role: value, dashboardId: this.dashboardId }, this.dashboardId); + permissions.addStoreItem({ permission: 1, role: value, dashboardId: dashboardId }, dashboardId); this.resetNewType(); return; }