From 7edc95cc35eca85fa8d6b64df4184a08ef97e542 Mon Sep 17 00:00:00 2001 From: Mitsuhiro Tanda Date: Mon, 16 Oct 2017 15:31:05 +0900 Subject: [PATCH] (cloudwatch) fix cloudwatch query error over 24h (#9536) fix cloudwatch query error over 24h --- public/app/plugins/datasource/cloudwatch/datasource.js | 2 +- .../plugins/datasource/cloudwatch/specs/datasource_specs.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/public/app/plugins/datasource/cloudwatch/datasource.js b/public/app/plugins/datasource/cloudwatch/datasource.js index c611111f2fa..8037cafb3e6 100644 --- a/public/app/plugins/datasource/cloudwatch/datasource.js +++ b/public/app/plugins/datasource/cloudwatch/datasource.js @@ -41,7 +41,7 @@ function (angular, _, moment, dateMath, kbn, templatingVariable) { item.namespace = templateSrv.replace(item.namespace, options.scopedVars); item.metricName = templateSrv.replace(item.metricName, options.scopedVars); item.dimensions = self.convertDimensionFormat(item.dimensions, options.scopeVars); - item.period = self.getPeriod(item, options); + item.period = String(self.getPeriod(item, options)); // use string format for period in graph query, and alerting return _.extend({ refId: item.refId, diff --git a/public/app/plugins/datasource/cloudwatch/specs/datasource_specs.ts b/public/app/plugins/datasource/cloudwatch/specs/datasource_specs.ts index 8642cc871f6..02312148b6a 100644 --- a/public/app/plugins/datasource/cloudwatch/specs/datasource_specs.ts +++ b/public/app/plugins/datasource/cloudwatch/specs/datasource_specs.ts @@ -37,7 +37,7 @@ describe('CloudWatchDatasource', function() { InstanceId: 'i-12345678' }, statistics: ['Average'], - period: 300 + period: '300' } ] }; @@ -109,7 +109,7 @@ describe('CloudWatchDatasource', function() { ctx.ds.query(query).then(function() { var params = requestParams.queries[0]; - expect(params.period).to.be(600); + expect(params.period).to.be('600'); done(); }); ctx.$rootScope.$apply();