Chore: Avoid unnecessary byte/string conversions (#69001)

Avoid unnecessary byte/string conversion

We can use alternative functions/methods to avoid unnecessary
byte/string conversion calls.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>

pkg/tsdb/azuremonitor/macros/macros.go

@@ -160,7 +160,7 @@ func (m *kqlMacroEngine) ReplaceAllStringSubmatchFunc(re *regexp.Regexp, str str
 	result := ""
 	lastIndex := 0
 
-	for _, v := range re.FindAllSubmatchIndex([]byte(str), -1) {
+	for _, v := range re.FindAllStringSubmatchIndex(str, -1) {
 		groups := []string{}
 		for i := 0; i < len(v); i += 2 {
 			if v[i] < 0 {

pkg/tsdb/influxdb/query.go

@@ -60,7 +60,7 @@ func (query *Query) renderTags() []string {
 
 		// If the operator is missing we fall back to sensible defaults
 		if tag.Operator == "" {
-			if regexpOperatorPattern.Match([]byte(tag.Value)) {
+			if regexpOperatorPattern.MatchString(tag.Value) {
 				tag.Operator = "=~"
 			} else {
 				tag.Operator = "="
@@ -124,7 +124,7 @@ func (query *Query) renderMeasurement() string {
 
 	measurement := query.Measurement
 
-	if !regexpMeasurementPattern.Match([]byte(measurement)) {
+	if !regexpMeasurementPattern.MatchString(measurement) {
 		measurement = fmt.Sprintf(`"%s"`, measurement)
 	}
 

pkg/tsdb/sqleng/sql_engine.go

@@ -1019,7 +1019,7 @@ func (m *SQLMacroEngineBase) ReplaceAllStringSubmatchFunc(re *regexp.Regexp, str
 	result := ""
 	lastIndex := 0
 
-	for _, v := range re.FindAllSubmatchIndex([]byte(str), -1) {
+	for _, v := range re.FindAllStringSubmatchIndex(str, -1) {
 		groups := []string{}
 		for i := 0; i < len(v); i += 2 {
 			groups = append(groups, str[v[i]:v[i+1]])