From 814707152d3d47a7a6cb21fc49846c3934446ffd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jean-Philippe=20Qu=C3=A9m=C3=A9ner?= Date: Mon, 26 May 2025 21:33:51 +0200 Subject: [PATCH] chore(unified-storage): contextualize the index build logger (#106025) --- pkg/storage/unified/resource/search.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pkg/storage/unified/resource/search.go b/pkg/storage/unified/resource/search.go index eacebd0d5d8..9133e59c045 100644 --- a/pkg/storage/unified/resource/search.go +++ b/pkg/storage/unified/resource/search.go @@ -540,13 +540,15 @@ func (s *searchSupport) build(ctx context.Context, nsr NamespacedResource, size ctx, span := s.tracer.Start(ctx, tracingPrexfixSearch+"Build") defer span.End() + logger := s.log.With("namespace", nsr.Namespace, "group", nsr.Group, "resource", nsr.Resource) + builder, err := s.builders.get(ctx, nsr) if err != nil { return nil, 0, err } fields := s.builders.GetFields(nsr) - s.log.Debug("Building index", "resource", nsr.Resource, "size", size, "rv", rv) + logger.Debug("Building index", "resource", nsr.Resource, "size", size, "rv", rv) index, err := s.search.BuildIndex(ctx, nsr, size, rv, fields, func(index ResourceIndex) (int64, error) { rv, err = s.storage.ListIterator(ctx, &resourcepb.ListRequest{ @@ -578,7 +580,7 @@ func (s *searchSupport) build(ctx context.Context, nsr NamespacedResource, size // Convert it to an indexable document doc, err := builder.BuildDocument(ctx, key, iter.ResourceVersion(), iter.Value()) if err != nil { - s.log.Error("error building search document", "key", SearchID(key), "err", err) + logger.Error("error building search document", "key", SearchID(key), "err", err) continue } @@ -609,7 +611,7 @@ func (s *searchSupport) build(ctx context.Context, nsr NamespacedResource, size // Record the number of objects indexed for the kind/resource docCount, err := index.DocCount(ctx, "") if err != nil { - s.log.Warn("error getting doc count", "error", err) + logger.Warn("error getting doc count", "error", err) } if s.indexMetrics != nil { s.indexMetrics.IndexedKinds.WithLabelValues(nsr.Resource).Add(float64(docCount))