From 827860d4595ac372b0e3ce1058c04cc33978fbe0 Mon Sep 17 00:00:00 2001
From: Yuri Tseretyan <yuriy.tseretyan@grafana.com>
Date: Thu, 14 Mar 2024 14:03:53 -0400
Subject: [PATCH] Alerting: Alerting accesscontrol utilities (#84508)

* create fake for accesscontrol.RuleService
* make errAuthorizationGeneric public
---
 .../ngalert/accesscontrol/fakes/rules.go      | 74 +++++++++++++++++++
 pkg/services/ngalert/accesscontrol/models.go  |  4 +-
 2 files changed, 76 insertions(+), 2 deletions(-)
 create mode 100644 pkg/services/ngalert/accesscontrol/fakes/rules.go

diff --git a/pkg/services/ngalert/accesscontrol/fakes/rules.go b/pkg/services/ngalert/accesscontrol/fakes/rules.go
new file mode 100644
index 00000000000..059f08e9157
--- /dev/null
+++ b/pkg/services/ngalert/accesscontrol/fakes/rules.go
@@ -0,0 +1,74 @@
+package fakes
+
+import (
+	"context"
+
+	"github.com/grafana/grafana/pkg/services/accesscontrol"
+	"github.com/grafana/grafana/pkg/services/auth/identity"
+	"github.com/grafana/grafana/pkg/services/ngalert/models"
+	"github.com/grafana/grafana/pkg/services/ngalert/store"
+)
+
+type Call struct {
+	MethodName string
+	Arguments  []interface{}
+}
+
+type FakeRuleService struct {
+	HasAccessFunc                        func(context.Context, identity.Requester, accesscontrol.Evaluator) (bool, error)
+	HasAccessOrErrorFunc                 func(context.Context, identity.Requester, accesscontrol.Evaluator, func() string) error
+	AuthorizeDatasourceAccessForRuleFunc func(context.Context, identity.Requester, *models.AlertRule) error
+	HasAccessToRuleGroupFunc             func(context.Context, identity.Requester, models.RulesGroup) (bool, error)
+	AuthorizeAccessToRuleGroupFunc       func(context.Context, identity.Requester, models.RulesGroup) error
+	AuthorizeRuleChangesFunc             func(context.Context, identity.Requester, *store.GroupDelta) error
+
+	Calls []Call
+}
+
+func (s *FakeRuleService) HasAccess(ctx context.Context, user identity.Requester, evaluator accesscontrol.Evaluator) (bool, error) {
+	s.Calls = append(s.Calls, Call{"HasAccess", []interface{}{ctx, user, evaluator}})
+	if s.HasAccessFunc != nil {
+		return s.HasAccessFunc(ctx, user, evaluator)
+	}
+	return false, nil
+}
+
+func (s *FakeRuleService) HasAccessOrError(ctx context.Context, user identity.Requester, evaluator accesscontrol.Evaluator, action func() string) error {
+	s.Calls = append(s.Calls, Call{"HasAccessOrError", []interface{}{ctx, user, evaluator, action}})
+	if s.HasAccessOrErrorFunc != nil {
+		return s.HasAccessOrErrorFunc(ctx, user, evaluator, action)
+	}
+	return nil
+}
+
+func (s *FakeRuleService) AuthorizeDatasourceAccessForRule(ctx context.Context, user identity.Requester, rule *models.AlertRule) error {
+	s.Calls = append(s.Calls, Call{"AuthorizeDatasourceAccessForRule", []interface{}{ctx, user, rule}})
+	if s.AuthorizeDatasourceAccessForRuleFunc != nil {
+		return s.AuthorizeDatasourceAccessForRuleFunc(ctx, user, rule)
+	}
+	return nil
+}
+
+func (s *FakeRuleService) HasAccessToRuleGroup(ctx context.Context, user identity.Requester, rules models.RulesGroup) (bool, error) {
+	s.Calls = append(s.Calls, Call{"HasAccessToRuleGroup", []interface{}{ctx, user, rules}})
+	if s.HasAccessToRuleGroupFunc != nil {
+		return s.HasAccessToRuleGroupFunc(ctx, user, rules)
+	}
+	return false, nil
+}
+
+func (s *FakeRuleService) AuthorizeAccessToRuleGroup(ctx context.Context, user identity.Requester, rules models.RulesGroup) error {
+	s.Calls = append(s.Calls, Call{"AuthorizeAccessToRuleGroup", []interface{}{ctx, user, rules}})
+	if s.AuthorizeAccessToRuleGroupFunc != nil {
+		return s.AuthorizeAccessToRuleGroupFunc(ctx, user, rules)
+	}
+	return nil
+}
+
+func (s *FakeRuleService) AuthorizeRuleChanges(ctx context.Context, user identity.Requester, change *store.GroupDelta) error {
+	s.Calls = append(s.Calls, Call{"AuthorizeRuleChanges", []interface{}{ctx, user, change}})
+	if s.AuthorizeRuleChangesFunc != nil {
+		return s.AuthorizeRuleChangesFunc(ctx, user, change)
+	}
+	return nil
+}
diff --git a/pkg/services/ngalert/accesscontrol/models.go b/pkg/services/ngalert/accesscontrol/models.go
index f3c93aaf2a7..49188277da4 100644
--- a/pkg/services/ngalert/accesscontrol/models.go
+++ b/pkg/services/ngalert/accesscontrol/models.go
@@ -8,12 +8,12 @@ import (
 )
 
 var (
-	errAuthorizationGeneric = errutil.Forbidden("alerting.unauthorized")
+	ErrAuthorizationBase = errutil.Forbidden("alerting.unauthorized")
 )
 
 func NewAuthorizationErrorWithPermissions(action string, eval accesscontrol.Evaluator) error {
 	msg := fmt.Sprintf("user is not authorized to %s", action)
-	err := errAuthorizationGeneric.Errorf(msg)
+	err := ErrAuthorizationBase.Errorf(msg)
 	err.PublicMessage = msg
 	if eval != nil {
 		err.PublicPayload = map[string]any{