Chore: remove xorm from preference (#53803)

* Chore: remove xorm from preference

* separte feature toggle

* fix comments

* fix comments

* remove the dublicated namedexec
This commit is contained in:
ying-jeanne
2022-08-17 22:07:20 -04:00
committed by GitHub
parent 4ac87a3b3b
commit 82b63688d2
10 changed files with 247 additions and 103 deletions
+12 -3
View File
@@ -12,12 +12,14 @@ import (
"github.com/stretchr/testify/require"
)
func TestIntegrationPreferencesDataAccess(t *testing.T) {
type getStore func(*sqlstore.SQLStore) store
func testIntegrationPreferencesDataAccess(t *testing.T, fn getStore) {
if testing.Short() {
t.Skip("skipping integration test")
}
ss := sqlstore.InitTestDB(t)
prefStore := sqlStore{db: ss}
prefStore := fn(ss)
orgNavbarPreferences := pref.NavbarPreference{
SavedItems: []pref.NavLink{{
ID: "alerting",
@@ -115,7 +117,7 @@ func TestIntegrationPreferencesDataAccess(t *testing.T) {
t.Run("Update for a user should only modify a single value", func(t *testing.T) {
ss := sqlstore.InitTestDB(t)
prefStore := sqlStore{db: ss}
prefStore := fn(ss)
id, err := prefStore.Insert(context.Background(), &pref.Preference{
UserID: user.SignedInUser{}.UserID,
Theme: "dark",
@@ -167,4 +169,11 @@ func TestIntegrationPreferencesDataAccess(t *testing.T) {
})
require.NoError(t, err)
})
t.Run("delete preference by user", func(t *testing.T) {
err := prefStore.DeleteByUser(context.Background(), user.SignedInUser{}.UserID)
require.NoError(t, err)
query := &pref.Preference{OrgID: 0, UserID: user.SignedInUser{}.UserID, TeamID: 0}
_, err = prefStore.Get(context.Background(), query)
require.EqualError(t, err, pref.ErrPrefNotFound.Error())
})
}