From 84150895341a595f8743d3677690b49ab1a94148 Mon Sep 17 00:00:00 2001
From: William Wernert <william.wernert@grafana.com>
Date: Wed, 15 Jan 2025 11:07:56 -0500
Subject: [PATCH] Alerting: Use correct status code for UID conflict in contact
 point provisionining API (#98970)

Use correct status code for UID conflict in contact point provisioning API
---
 pkg/services/ngalert/api/api_provisioning.go       |  2 +-
 pkg/services/ngalert/provisioning/contactpoints.go |  5 +----
 pkg/services/ngalert/provisioning/errors.go        | 13 +++++++++++++
 3 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/pkg/services/ngalert/api/api_provisioning.go b/pkg/services/ngalert/api/api_provisioning.go
index cdbe810597b..935cf1bc8d3 100644
--- a/pkg/services/ngalert/api/api_provisioning.go
+++ b/pkg/services/ngalert/api/api_provisioning.go
@@ -171,7 +171,7 @@ func (srv *ProvisioningSrv) RoutePostContactPoint(c *contextmodel.ReqContext, cp
 		return ErrResp(http.StatusBadRequest, err, "")
 	}
 	if err != nil {
-		return ErrResp(http.StatusInternalServerError, err, "")
+		return response.ErrOrFallback(http.StatusInternalServerError, "", err)
 	}
 	return response.JSON(http.StatusAccepted, contactPoint)
 }
diff --git a/pkg/services/ngalert/provisioning/contactpoints.go b/pkg/services/ngalert/provisioning/contactpoints.go
index 9bde1c86b17..d5fe345ca3d 100644
--- a/pkg/services/ngalert/provisioning/contactpoints.go
+++ b/pkg/services/ngalert/provisioning/contactpoints.go
@@ -198,10 +198,7 @@ func (ecp *ContactPointService) CreateContactPoint(
 		// check if uid is already used in receiver
 		for _, rec := range receiver.PostableGrafanaReceivers.GrafanaManagedReceivers {
 			if grafanaReceiver.UID == rec.UID {
-				return apimodels.EmbeddedContactPoint{}, fmt.Errorf(
-					"receiver configuration with UID '%s' already exist in contact point '%s'. Please use unique identifiers for receivers across all contact points",
-					rec.UID,
-					rec.Name)
+				return apimodels.EmbeddedContactPoint{}, MakeErrContactPointUidExists(rec.UID, rec.Name)
 			}
 		}
 		if receiver.Name == contactPoint.Name {
diff --git a/pkg/services/ngalert/provisioning/errors.go b/pkg/services/ngalert/provisioning/errors.go
index f13d2315df5..3d8b4c85608 100644
--- a/pkg/services/ngalert/provisioning/errors.go
+++ b/pkg/services/ngalert/provisioning/errors.go
@@ -28,6 +28,10 @@ var (
 
 	ErrContactPointReferenced = errutil.Conflict("alerting.notifications.contact-points.referenced", errutil.WithPublicMessage("Contact point is currently referenced by a notification policy."))
 	ErrContactPointUsedInRule = errutil.Conflict("alerting.notifications.contact-points.used-by-rule", errutil.WithPublicMessage("Contact point is currently used in the notification settings of one or many alert rules."))
+	contactPointUidExists     = "Receiver configuration with UID '{{ .Public.UID }}' already exists in contact point '{{ .Public.Name }}'. Please use unique identifiers for receivers across all contact points."
+	ErrContactPointUidExists  = errutil.Conflict("alerting.notifications.contact-points.uidInUse").MustTemplate(
+		contactPointUidExists, errutil.WithPublic(contactPointUidExists),
+	)
 
 	ErrRouteInvalidFormat = errutil.BadRequest("alerting.notifications.routes.invalidFormat").MustTemplate(
 		"Invalid format of the submitted route.",
@@ -104,3 +108,12 @@ func MakeErrRouteInvalidFormat(err error) error {
 		Error: err,
 	})
 }
+
+func MakeErrContactPointUidExists(uid, name string) error {
+	return ErrContactPointUidExists.Build(errutil.TemplateData{
+		Public: map[string]any{
+			"UID":  uid,
+			"Name": name,
+		},
+	})
+}