public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prometheus/Promlib: Remove the PrometheusDataplane feature so always enabled (#92218)

Browse Source 
This has been default behavior since v10

---------

Co-authored-by: Brendan O'Handley <brendan.ohandley@grafana.com>
This commit is contained in:
Kyle Brandt
2024-08-26 08:53:38 -04:00
committed by GitHub
co-authored by Brendan O'Handley
parent fa95eb8c02
commit 84e5c3af22
17 changed files with 106 additions and 138 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/services/featuremgmt/registry.go
-8
View File
@@ -318,14 +318,6 @@ var (
FrontendOnly: false,
Owner: grafanaObservabilityMetricsSquad,
},
{
Name: "prometheusDataplane",
Description: "Changes responses to from Prometheus to be compliant with the dataplane specification. In particular, when this feature toggle is active, the numeric `Field.Name` is set from 'Value' to the value of the `__name__` label.",
Expression: "true",
Stage: FeatureStageGeneralAvailability,
Owner: grafanaObservabilityMetricsSquad,
AllowSelfServe: true,
},
{
Name: "lokiMetricDataplane",
Description: "Changes metric responses from Loki to be compliant with the dataplane specification.",
pkg/services/featuremgmt/toggles_gen.csv
-1
View File
@@ -40,7 +40,6 @@ influxdbBackendMigration,GA,@grafana/observability-metrics,false,false,true
influxqlStreamingParser,experimental,@grafana/observability-metrics,false,false,false
influxdbRunQueriesInParallel,privatePreview,@grafana/observability-metrics,false,false,false
prometheusRunQueriesInParallel,privatePreview,@grafana/observability-metrics,false,false,false
prometheusDataplane,GA,@grafana/observability-metrics,false,false,false
lokiMetricDataplane,GA,@grafana/observability-logs,false,false,false
lokiLogsDataplane,experimental,@grafana/observability-logs,false,false,false
dataplaneFrontendFallback,GA,@grafana/observability-metrics,false,false,true
1 Name Stage Owner requiresDevMode RequiresRestart FrontendOnly
40 influxqlStreamingParser experimental @grafana/observability-metrics false false false
41 influxdbRunQueriesInParallel privatePreview @grafana/observability-metrics false false false
42 prometheusRunQueriesInParallel privatePreview @grafana/observability-metrics false false false
prometheusDataplane GA @grafana/observability-metrics false false false
43 lokiMetricDataplane GA @grafana/observability-logs false false false
44 lokiLogsDataplane experimental @grafana/observability-logs false false false
45 dataplaneFrontendFallback GA @grafana/observability-metrics false false true
pkg/services/featuremgmt/toggles_gen.go
-4
View File
@@ -171,10 +171,6 @@ const (
// Enables running Prometheus queries in parallel
FlagPrometheusRunQueriesInParallel = "prometheusRunQueriesInParallel"
// FlagPrometheusDataplane
// Changes responses to from Prometheus to be compliant with the dataplane specification. In particular, when this feature toggle is active, the numeric `Field.Name` is set from &#39;Value&#39; to the value of the `__name__` label.
FlagPrometheusDataplane = "prometheusDataplane"
// FlagLokiMetricDataplane
// Changes metric responses from Loki to be compliant with the dataplane specification.
FlagLokiMetricDataplane = "lokiMetricDataplane"
pkg/services/featuremgmt/toggles_gen.json
+2
View File
@@ -1619,6 +1619,7 @@
"name": "lokiMetricDataplane",
"resourceVersion": "1720021873452",
"creationTimestamp": "2023-04-13T13:07:08Z",
"deletionTimestamp": "2024-08-21T13:49:48Z",
"annotations": {
"grafana.app/updatedTimestamp": "2024-07-03 15:51:13.452477 +0000 UTC"
}
@@ -2184,6 +2185,7 @@
"name": "prometheusDataplane",
"resourceVersion": "1720021873452",
"creationTimestamp": "2023-03-29T15:26:32Z",
"deletionTimestamp": "2024-08-21T13:35:19Z",
"annotations": {
"grafana.app/updatedTimestamp": "2024-07-03 15:51:13.452477 +0000 UTC"
}