extract kindsys to external library (#64562)

* extract kindsys

* reinstate kindsys report

This may end up living somewhere else (or not! who knows!), but the important part is that I don't get rid of it right now :)

I hate the package layout (kindsysreport/codegen) for the main function and will take pretty much any alternative suggestion, but we can change also change it later.

Note that the generated report.json is in a different location - anything using this (ops something) needs to be updated.

* kindsysreport in codeowners

pkg/codegen/tmpl/core_crd_registry.tmpl

@@ -6,8 +6,8 @@ import (
 
 	{{range .Kinds }}
 	{{ .Props.MachineName }} "{{ $.KindPackagePrefix }}/{{ .Props.MachineName }}/crd"{{end}}
-	"github.com/grafana/grafana/pkg/kindsys"
-	"github.com/grafana/grafana/pkg/kindsys/k8ssys"
+	"github.com/grafana/kindsys"
+	"github.com/grafana/kindsys/k8ssys"
 	"github.com/grafana/grafana/pkg/registry/corekind"
 	"gopkg.in/yaml.v3"
 )

pkg/codegen/tmpl/core_crd_types.tmpl

@@ -4,7 +4,7 @@ import (
   _ "embed"
 
   "github.com/grafana/grafana/pkg/kinds/{{ .Props.MachineName }}"
-  "github.com/grafana/grafana/pkg/kindsys/k8ssys"
+  "github.com/grafana/kindsys/k8ssys"
 )
 
 // The CRD YAML representation of the {{ .Props.Name }} kind.

pkg/codegen/tmpl/kind_core.tmpl

@@ -1,9 +1,11 @@
 package {{ .Props.MachineName }}
 
 import (
-	"github.com/grafana/grafana/pkg/kindsys"
+	"github.com/grafana/kindsys"
 	"github.com/grafana/thema"
 	"github.com/grafana/thema/vmux"
+
+	"github.com/grafana/grafana/pkg/cuectx"
 )
 
 // rootrel is the relative path from the grafana repository root to the
@@ -25,7 +27,7 @@ var _ kindsys.Core = &Kind{}
 
 // TODO standard generated docs
 func NewKind(rt *thema.Runtime, opts ...thema.BindOption) (*Kind, error) {
-	def, err := kindsys.LoadCoreKindDef(rootrel, rt.Context(), nil)
+	def, err := cuectx.LoadCoreKindDef(rootrel, rt.Context(), nil)
 	if err != nil {
 		return nil, err
 	}

pkg/codegen/tmpl/kind_registry.tmpl

@@ -7,7 +7,7 @@ import (
 	{{range .Kinds }}
 	"{{ $.KindPackagePrefix }}/{{ .Props.MachineName }}"{{end}}
 	"github.com/grafana/grafana/pkg/cuectx"
-	"github.com/grafana/grafana/pkg/kindsys"
+	"github.com/grafana/kindsys"
 	"github.com/grafana/thema"
 )
 

pkg/codegen/tmpl/plugin_lineage_file.tmpl

@@ -7,9 +7,10 @@ import (
 	"path/filepath"
 	"sync"
 
+	"github.com/grafana/thema"
+
 	"github.com/grafana/grafana/pkg/cuectx"
 	"github.com/grafana/grafana/pkg/plugins/pfs"
-	"github.com/grafana/thema"
 )
 
 var parseOnce sync.Once