From 8766daa3c0a13aa7ffcf9546a20d26741d453cb1 Mon Sep 17 00:00:00 2001 From: Sergej-Vlasov <37613182+Sergej-Vlasov@users.noreply.github.com> Date: Fri, 2 May 2025 09:32:28 +0100 Subject: [PATCH] E2E: Align on how to use feature toggles in cypress tests (#104831) align on how to use feature toggles in cypress tests --- e2e/cypress/support/e2e.js | 7 +------ e2e/run-suite | 4 ++-- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/e2e/cypress/support/e2e.js b/e2e/cypress/support/e2e.js index 29385190b9c..912e99494cc 100644 --- a/e2e/cypress/support/e2e.js +++ b/e2e/cypress/support/e2e.js @@ -46,16 +46,11 @@ Cypress.on('uncaught:exception', (err) => { // // TODO: read from toggles_gen.csv? -const featureToggles = ['kubernetesDashboards', 'dashboardNewLayouts']; +const featureToggles = ['kubernetesDashboards', 'dashboardNewLayouts', 'dashboardScene']; beforeEach(() => { let toggles = []; - if (Cypress.env('DISABLE_SCENES')) { - cy.logToConsole('disabling dashboardScene feature toggle in localstorage'); - toggles.push('dashboardScene=false'); - } - for (const toggle of featureToggles) { const toggleValue = Cypress.env(toggle); if (toggleValue !== undefined) { diff --git a/e2e/run-suite b/e2e/run-suite index c5d1f896a35..c339060bd89 100755 --- a/e2e/run-suite +++ b/e2e/run-suite @@ -92,7 +92,7 @@ case "$1" in "") ;; "old-arch") - env[DISABLE_SCENES]=true + env[dashboardScene]=false cypressConfig[specPattern]=$rootForOldArch/*/$testFilesForSingleSuite cypressConfig[video]=false case "$2" in @@ -112,7 +112,7 @@ case "$1" in "old-arch/"*) cypressConfig[specPattern]=./e2e/"${args[0]}"/$testFilesForSingleSuite cypressConfig[video]=${args[1]} - env[DISABLE_SCENES]=true + env[dashboardScene]=false ;; "dashboards-schema-v2") env[kubernetesDashboards]=true