User: remove empty email / username check from update in service (#77347)

User: remove empty email / username check from update in service
This commit is contained in:
Karl Persson
2023-10-30 10:44:26 +01:00
committed by GitHub
parent f5d04a067e
commit 87eba34745
3 changed files with 9 additions and 19 deletions
+9
View File
@@ -221,6 +221,15 @@ func (hs *HTTPServer) handleUpdateUser(ctx context.Context, cmd user.UpdateUserC
return response.Error(http.StatusForbidden, "User info cannot be updated for external Users", nil)
}
if len(cmd.Login) == 0 {
cmd.Login = cmd.Email
}
// if login is still empty both email and login field is missing
if len(cmd.Login) == 0 {
return response.Err(user.ErrEmptyUsernameAndEmail.Errorf("user cannot be created with empty username and email"))
}
if err := hs.userService.Update(ctx, &cmd); err != nil {
if errors.Is(err, user.ErrCaseInsensitive) {
return response.Error(http.StatusConflict, "Update would result in user login conflict", err)