public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Loki: Update copy for missing label filter error message (#53449)

Browse Source 
* Loki: Update copy for missing label filter

* Update
This commit is contained in:
Ivana Huckova
2022-08-11 17:57:10 +02:00
committed by GitHub
parent 6592b03f12
commit 8813cbfb62
3 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/various-suite/loki-query-builder.spec.ts
+3 -2
View File
@@ -1,5 +1,6 @@
import { e2e } from '@grafana/e2e';
const MISSING_LABEL_FILTER_ERROR_MESSAGE = 'Select at least 1 label filter (label and value)';
const dataSourceName = 'LokiBuilder';
const addDataSource = () => {
e2e.flows.addDataSource({
@@ -56,7 +57,7 @@ describe('Loki query builder', () => {
e2e().contains('rate({} | logfmt | __error__=`` [$__interval]').should('be.visible');
// Check for expected error
e2e().contains('You need to specify at least 1 label filter (stream selector)').should('be.visible');
e2e().contains(MISSING_LABEL_FILTER_ERROR_MESSAGE).should('be.visible');
// Add labels to remove error
e2e.components.QueryBuilder.labelSelect().should('be.visible').click().type('instance{enter}');
@@ -66,7 +67,7 @@ describe('Loki query builder', () => {
.click()
.type('instance1{enter}')
.type('instance2{enter}');
e2e().contains('You need to specify at least 1 label filter (stream selector)').should('not.exist');
e2e().contains(MISSING_LABEL_FILTER_ERROR_MESSAGE).should('not.exist');
e2e().contains(finalQuery).should('be.visible');
// Switch to code editor and check if query was parsed