From 88d991ef45a5f74b3447017dd9597ba90adb5044 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Torkel=20=C3=96degaard?= <torkel.odegaard@gmail.com>
Date: Fri, 15 Aug 2014 17:23:27 +0200
Subject: [PATCH] Another angular binding/watcher optimization

---
 src/app/controllers/row.js       | 13 +++++++++++++
 src/app/panels/graph/module.html |  3 +--
 src/app/panels/graph/module.js   |  2 +-
 src/app/partials/dashboard.html  |  2 +-
 4 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/src/app/controllers/row.js b/src/app/controllers/row.js
index d2f87e029cc..314559405ea 100644
--- a/src/app/controllers/row.js
+++ b/src/app/controllers/row.js
@@ -124,4 +124,17 @@ function (angular, app, _) {
     };
   });
 
+  module.directive('panelDropZone', function() {
+    return function(scope, element) {
+      scope.$watch('dashboard.$$panelDragging', function(newVal) {
+        if (newVal && scope.dashboard.rowSpan(scope.row) < 10) {
+          element.show();
+        }
+        else {
+          element.hide();
+        }
+      });
+    };
+  });
+
 });
diff --git a/src/app/panels/graph/module.html b/src/app/panels/graph/module.html
index 385ba8b79a0..102cad84a40 100644
--- a/src/app/panels/graph/module.html
+++ b/src/app/panels/graph/module.html
@@ -1,5 +1,4 @@
-<div  ng-controller='GraphCtrl'
-      >
+<div  ng-controller='GraphCtrl'>
 
   <div class="graph-wrapper" ng-class="{'graph-legend-rightside': panel.legend.rightSide}">
       <div class="graph-canvas-wrapper">
diff --git a/src/app/panels/graph/module.js b/src/app/panels/graph/module.js
index 3dba7c096cb..647e52c257e 100644
--- a/src/app/panels/graph/module.js
+++ b/src/app/panels/graph/module.js
@@ -243,7 +243,7 @@ function (angular, app, $, _, kbn, moment, timeSeries) {
 
       var data = _.map(results.data, $scope.seriesHandler);
 
-      $scope.datapointsWarning = $scope.datapointsCount || !$scope.datapointsOutside;
+      $scope.datapointsWarning = $scope.datapointsCount === 0 || $scope.datapointsOutside;
 
       $scope.annotationsPromise
         .then(function(annotations) {
diff --git a/src/app/partials/dashboard.html b/src/app/partials/dashboard.html
index b506287eec7..265fd640820 100644
--- a/src/app/partials/dashboard.html
+++ b/src/app/partials/dashboard.html
@@ -110,7 +110,7 @@
                 <grafana-panel type="panel.type" ng-cloak></grafana-panel>
               </div>
 
-              <div ng-show="dashboard.rowSpan(row) < 10 && dashboard.$$panelDragging" class="panel" style="margin:5px;width:30%;background:rgba(100,100,100,0.50)" ng-class="{'dragInProgress':dashboard.panelDragging}" ng-style="{height:row.height}" data-drop="true" ng-model="row.panels" data-jqyoui-options jqyoui-droppable="{index:row.panels.length,mutate:false,onDrop:'panelMoveDrop',onOver:'panelMoveOver',onOut:'panelMoveOut'}">
+              <div panel-drop-zone class="panel dragInProgress" style="margin:5px;width:30%;background:rgba(100,100,100,0.50)" ng-style="{height:row.height}" data-drop="true" ng-model="row.panels" data-jqyoui-options jqyoui-droppable="{index:row.panels.length,mutate:false,onDrop:'panelMoveDrop',onOver:'panelMoveOver',onOut:'panelMoveOut'}">
               </div>
 
               <div class="clearfix"></div>