public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "DashList: Update variables in links when they change" (#77868)

Browse Source 
Revert "DashList: Update variables in links when they change (#77787)"

This reverts commit 3e57eacc15.
This commit is contained in:
Torkel Ödegaard
2023-11-08 14:05:59 +01:00
committed by GitHub
parent 3e57eacc15
commit 88f35fc85f
4 changed files with 2 additions and 215 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/panels-suite/dashlist.spec.ts
-37
View File
@@ -1,37 +0,0 @@
import { e2e } from '../utils';
const PAGE_UNDER_TEST = 'a6801696-cc53-4196-b1f9-2403e3909185/panel-tests-dashlist-variables';
describe('DashList panel', () => {
beforeEach(() => {
e2e.flows.login(Cypress.env('USERNAME'), Cypress.env('PASSWORD'));
});
// this is to prevent the fix for https://github.com/grafana/grafana/issues/76800 from regressing
it('should pass current variable values correctly when `Include current template variable values` is set', () => {
e2e.flows.openDashboard({ uid: PAGE_UNDER_TEST });
// check the initial value of the urls contain the variable value correctly
e2e.components.Panels.Panel.title('Dashboard list panel')
.should('be.visible')
.within(() => {
cy.get('a').each(($el) => {
cy.wrap($el).should('have.attr', 'href').and('contain', 'var-query0=a');
});
});
// update variable to b
e2e.pages.Dashboard.SubMenu.submenuItemLabels('query0').click();
e2e.pages.Dashboard.SubMenu.submenuItemValueDropDownOptionTexts('b').click();
// blur the dropdown
cy.get('body').click();
// check the urls are updated with the new variable value
e2e.components.Panels.Panel.title('Dashboard list panel')
.should('be.visible')
.within(() => {
cy.get('a').each(($el) => {
cy.wrap($el).should('have.attr', 'href').and('contain', 'var-query0=b');
});
});
});
});