public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

oauth: raise error if session state is missing

Browse Source 
ref #9476
This commit is contained in:
bergquist
2017-10-12 15:25:27 +02:00
parent 0848ba2e9c
commit 88f55b01d8
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/api/login_oauth.go
+6 -2
View File
@@ -71,8 +71,12 @@ func OAuthLogin(ctx *middleware.Context) {
return return
} }
// verify state string savedState, ok := ctx.Session.Get(middleware.SESS_KEY_OAUTH_STATE).(string)
savedState := ctx.Session.Get(middleware.SESS_KEY_OAUTH_STATE).(string) if !ok {
ctx.Handle(500, "login.OAuthLogin(missing saved state)", nil)
return
}
queryState := ctx.Query("state") queryState := ctx.Query("state")
if savedState != queryState { if savedState != queryState {
ctx.Handle(500, "login.OAuthLogin(state mismatch)", nil) ctx.Handle(500, "login.OAuthLogin(state mismatch)", nil)