SQLStore: Fix wrong usage of xorm's insert functions in tests (#63850)
* SQLStore: Fix InsertId * Prefs: Fix Insert return value * Fix tests * Add guidelines
This commit is contained in:
@@ -172,7 +172,7 @@ func (ss *SQLStore) getOrCreateOrg(sess *DBSession, orgName string) (int64, erro
|
||||
org.Updated = time.Now()
|
||||
|
||||
if org.ID != 0 {
|
||||
if _, err := sess.InsertId(&org, ss.Dialect); err != nil {
|
||||
if err := sess.InsertId(&org, ss.Dialect); err != nil {
|
||||
return 0, err
|
||||
}
|
||||
} else {
|
||||
|
||||
Reference in New Issue
Block a user