From 895baa95a0af0e2df27ad3704e3d83398b2293fb Mon Sep 17 00:00:00 2001 From: Ivan Ortega Alba Date: Thu, 27 Jun 2024 17:26:38 +0200 Subject: [PATCH] VizPanelManager: Adapt color palete after plugin change (#89790) * VizPanelManager: Adapt color palete after plugin change * Upgrade scenes * Remove broken code * Upgrade scenes version * linter --- package.json | 2 +- .../dashboard-scene/panel-edit/VizPanelManager.tsx | 3 ++- yarn.lock | 10 +++++----- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/package.json b/package.json index 452a65bccfd..a1c1c238a8b 100644 --- a/package.json +++ b/package.json @@ -260,7 +260,7 @@ "@grafana/prometheus": "workspace:*", "@grafana/runtime": "workspace:*", "@grafana/saga-icons": "workspace:*", - "@grafana/scenes": "^5.3.0", + "@grafana/scenes": "5.3.2", "@grafana/schema": "workspace:*", "@grafana/sql": "workspace:*", "@grafana/ui": "workspace:*", diff --git a/public/app/features/dashboard-scene/panel-edit/VizPanelManager.tsx b/public/app/features/dashboard-scene/panel-edit/VizPanelManager.tsx index 1ffb2272d93..40ae36a0958 100644 --- a/public/app/features/dashboard-scene/panel-edit/VizPanelManager.tsx +++ b/public/app/features/dashboard-scene/panel-edit/VizPanelManager.tsx @@ -267,8 +267,9 @@ export class VizPanelManager extends SceneObjectBase { }; const newOptions = newPlugin?.onPanelTypeChanged?.(panel, prevPluginId, prevOptions, prevFieldConfig); + if (newOptions) { - newPanel.onOptionsChange(newOptions, true); + newPanel.onOptionsChange(newOptions, true, true); } if (newPlugin?.onPanelMigration) { diff --git a/yarn.lock b/yarn.lock index 393f7b62e03..9b14c407e32 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3580,9 +3580,9 @@ __metadata: languageName: unknown linkType: soft -"@grafana/scenes@npm:^5.3.0": - version: 5.3.0 - resolution: "@grafana/scenes@npm:5.3.0" +"@grafana/scenes@npm:5.3.2": + version: 5.3.2 + resolution: "@grafana/scenes@npm:5.3.2" dependencies: "@grafana/e2e-selectors": "npm:^11.0.0" "@leeoniya/ufuzzy": "npm:^1.0.14" @@ -3597,7 +3597,7 @@ __metadata: "@grafana/ui": ^10.4.1 react: ^18.0.0 react-dom: ^18.0.0 - checksum: 10/625b7e009af1b79de8903eb2fbe9e2da3558e229d51e532bbb385bc72c316f9a5df9e1e81caff49e3b245dd1e00a019331f4ce11cdd980fe112917992c80c3c2 + checksum: 10/90d2dd3b6daa293589a8933de8169d51814956ab4b425d2b5f750b3d504080944373345bce84e6a18a28260cc6fd9bf58c4e4046092a87d8ff0104b085f63e6d languageName: node linkType: hard @@ -17145,7 +17145,7 @@ __metadata: "@grafana/prometheus": "workspace:*" "@grafana/runtime": "workspace:*" "@grafana/saga-icons": "workspace:*" - "@grafana/scenes": "npm:^5.3.0" + "@grafana/scenes": "npm:5.3.2" "@grafana/schema": "workspace:*" "@grafana/sql": "workspace:*" "@grafana/tsconfig": "npm:^1.3.0-rc1"