From 8a5fe5b0dfc7e46d291050d9cce52444993e503a Mon Sep 17 00:00:00 2001 From: bergquist Date: Thu, 28 Dec 2017 14:37:10 +0100 Subject: [PATCH] renderer: avoid calling Handle twice --- pkg/api/render.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pkg/api/render.go b/pkg/api/render.go index be85da35853..65733cfab15 100644 --- a/pkg/api/render.go +++ b/pkg/api/render.go @@ -31,11 +31,12 @@ func RenderToPng(c *middleware.Context) { pngPath, err := renderer.RenderToPng(renderOpts) - if err != nil { - if err == renderer.ErrTimeout { - c.Handle(500, err.Error(), err) - } + if err != nil && err == renderer.ErrTimeout { + c.Handle(500, err.Error(), err) + return + } + if err != nil { c.Handle(500, "Rendering failed.", err) return }