From 8ab9559076443bc285de1a082bb8cb98a54e2502 Mon Sep 17 00:00:00 2001 From: Mihaly Gyongyosi Date: Tue, 16 Sep 2025 09:07:39 +0200 Subject: [PATCH] Address feedback --- pkg/registry/apis/iam/legacy/service_account.go | 5 ----- pkg/registry/apis/iam/legacy/user.go | 5 ----- 2 files changed, 10 deletions(-) diff --git a/pkg/registry/apis/iam/legacy/service_account.go b/pkg/registry/apis/iam/legacy/service_account.go index b97c54ae8d7..3619d9a478f 100644 --- a/pkg/registry/apis/iam/legacy/service_account.go +++ b/pkg/registry/apis/iam/legacy/service_account.go @@ -445,11 +445,6 @@ func (s *legacySQLStore) DeleteServiceAccount(ctx context.Context, ns claims.Nam return fmt.Errorf("failed to scan user ID: %w", err) } - // Close rows to avoid the bad connection error - if rows != nil { - _ = rows.Close() - } - orgUserReq := newDeleteOrgUser(sql, userID) if err := orgUserReq.Validate(); err != nil { return err diff --git a/pkg/registry/apis/iam/legacy/user.go b/pkg/registry/apis/iam/legacy/user.go index 733230b3266..5538e5e876e 100644 --- a/pkg/registry/apis/iam/legacy/user.go +++ b/pkg/registry/apis/iam/legacy/user.go @@ -546,11 +546,6 @@ func (s *legacySQLStore) DeleteUser(ctx context.Context, ns claims.NamespaceInfo return fmt.Errorf("failed to scan user ID: %w", err) } - // Close rows to avoid the bad connection error - if rows != nil { - _ = rows.Close() - } - orgUserReq := deleteOrgUserQuery{ SQLTemplate: sqltemplate.New(sql.DialectForDriver()), OrgUserTable: sql.Table("org_user"),