public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #13448 from grafana/davkal/typecheck-precommit

Browse Source 
Compile TS on precommit hook
This commit is contained in:
Torkel Ödegaard
2018-09-27 15:36:50 +02:00
committed by GitHub
parent 5873a71324 88f36cbd22
commit 8b4dbbe0bd
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/grunt/default_task.js
+5 -4
View File
@@ -1,5 +1,5 @@
// Lint and build CSS // Lint and build CSS
module.exports = function(grunt) { module.exports = function (grunt) {
'use strict'; 'use strict';
grunt.registerTask('default', [ grunt.registerTask('default', [
@@ -18,15 +18,16 @@ module.exports = function(grunt) {
grunt.registerTask('precommit', [ grunt.registerTask('precommit', [
'sasslint', 'sasslint',
'exec:tslint', 'exec:tslint',
'exec:tsc',
'no-only-tests' 'no-only-tests'
]); ]);
grunt.registerTask('no-only-tests', function() { grunt.registerTask('no-only-tests', function () {
var files = grunt.file.expand('public/**/*_specs\.ts', 'public/**/*_specs\.js'); var files = grunt.file.expand('public/**/*_specs\.ts', 'public/**/*_specs\.js');
files.forEach(function(spec) { files.forEach(function (spec) {
var rows = grunt.file.read(spec).split('\n'); var rows = grunt.file.read(spec).split('\n');
rows.forEach(function(row) { rows.forEach(function (row) {
if (row.indexOf('.only(') > 0) { if (row.indexOf('.only(') > 0) {
grunt.log.errorlns(row); grunt.log.errorlns(row);
grunt.fail.warn('found only statement in test: ' + spec) grunt.fail.warn('found only statement in test: ' + spec)
scripts/grunt/options/exec.js
+2 -1
View File
@@ -1,8 +1,9 @@
module.exports = function(config, grunt) { module.exports = function (config, grunt) {
'use strict'; 'use strict';
return { return {
tslint: 'node ./node_modules/tslint/lib/tslintCli.js -c tslint.json --project ./tsconfig.json', tslint: 'node ./node_modules/tslint/lib/tslintCli.js -c tslint.json --project ./tsconfig.json',
tsc: 'yarn tsc --noEmit',
jest: 'node ./node_modules/jest-cli/bin/jest.js --maxWorkers 2', jest: 'node ./node_modules/jest-cli/bin/jest.js --maxWorkers 2',
webpack: 'node ./node_modules/webpack/bin/webpack.js --config scripts/webpack/webpack.prod.js', webpack: 'node ./node_modules/webpack/bin/webpack.js --config scripts/webpack/webpack.prod.js',
}; };