From 8b82bebdc559724ae1e889f93bba36409a627ac5 Mon Sep 17 00:00:00 2001 From: Karl Persson Date: Wed, 22 Jun 2022 15:49:32 +0200 Subject: [PATCH] RolePicker: Only select roles that is delegatable when selecting a group (#51246) --- public/app/core/components/RolePicker/RolePickerMenu.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/public/app/core/components/RolePicker/RolePickerMenu.tsx b/public/app/core/components/RolePicker/RolePickerMenu.tsx index a85fd804381..121b7b1b787 100644 --- a/public/app/core/components/RolePicker/RolePickerMenu.tsx +++ b/public/app/core/components/RolePicker/RolePickerMenu.tsx @@ -118,14 +118,15 @@ export const RolePickerMenu = ({ const group = optionGroups.find((g) => { return g.value === value; }); - if (groupSelected(value)) { + if (groupSelected(value) || groupPartiallySelected(value)) { if (group) { setSelectedOptions(selectedOptions.filter((role) => !group.options.find((option) => role.uid === option.uid))); } } else { if (group) { + const groupOptions = group.options.filter((role) => role.delegatable); const restOptions = selectedOptions.filter((role) => !group.options.find((option) => role.uid === option.uid)); - setSelectedOptions([...restOptions, ...group.options]); + setSelectedOptions([...restOptions, ...groupOptions]); } } };