diff --git a/packages/grafana-ui/src/utils/processTimeSeries.ts b/packages/grafana-ui/src/utils/processTimeSeries.ts index d8827e567e3..4b64ae3dd99 100644 --- a/packages/grafana-ui/src/utils/processTimeSeries.ts +++ b/packages/grafana-ui/src/utils/processTimeSeries.ts @@ -8,13 +8,28 @@ import { TimeSeriesVMs, NullValueMode, TimeSeriesValue, TableData } from '../typ interface Options { data: TableData[]; - xColumn: number; // Time - yColumn: number; // Value + xColumn?: number; // Time + yColumn?: number; // Value nullValueMode: NullValueMode; } export function processTimeSeries({ data, xColumn, yColumn, nullValueMode }: Options): TimeSeriesVMs { const vmSeries = data.map((item, index) => { + if (!isNumber(xColumn)) { + xColumn = 1; // Default timeseries colum. TODO, find first time field! + } + if (!isNumber(yColumn)) { + yColumn = 0; // TODO, find first non-time field + } + + // TODO? either % or throw error? + if (xColumn >= item.columns.length) { + throw new Error('invalid colum: ' + xColumn); + } + if (yColumn >= item.columns.length) { + throw new Error('invalid colum: ' + yColumn); + } + const colorIndex = index % colors.length; const label = item.columns[yColumn].text; const result = []; diff --git a/public/app/features/dashboard/dashgrid/DataPanel.tsx b/public/app/features/dashboard/dashgrid/DataPanel.tsx index c12462e2b49..1dd62c58e5c 100644 --- a/public/app/features/dashboard/dashgrid/DataPanel.tsx +++ b/public/app/features/dashboard/dashgrid/DataPanel.tsx @@ -145,12 +145,10 @@ export class DataPanel extends Component { onDataResponse(resp); } - const data = toTableData(resp.data); - console.log('Converted:', data); this.setState({ loading: LoadingState.Done, response: resp, - data, + data: toTableData(resp.data), isFirstLoad: false, }); } catch (err) { @@ -190,8 +188,6 @@ export class DataPanel extends Component { ); } - console.log('RENDER', data); - return ( <> {loading === LoadingState.Loading && this.renderLoadingState()} diff --git a/public/app/plugins/panel/gauge/GaugePanel.tsx b/public/app/plugins/panel/gauge/GaugePanel.tsx index 7913aa33eb0..c4df1bb48ca 100644 --- a/public/app/plugins/panel/gauge/GaugePanel.tsx +++ b/public/app/plugins/panel/gauge/GaugePanel.tsx @@ -22,12 +22,9 @@ export class GaugePanel extends Component { this.state = { value: this.findValue(props), }; - console.log('CONSTRUCTOR!', this.props.data); } componentDidUpdate(prevProps: Props) { - console.log('UPDATE', this.props.data); - if (this.props.data !== prevProps.data) { this.setState({ value: this.findValue(this.props) }); } @@ -37,21 +34,12 @@ export class GaugePanel extends Component { const { data, options } = props; const { valueOptions } = options; - console.log('FIND VALUE', data); - if (data) { - // For now, assume timeseries defaults - const xColumn = 1; // time - const yColumn = 0; // value const vmSeries = processTimeSeries({ data, - xColumn, - yColumn, nullValueMode: NullValueMode.Null, }); - console.log('GOT', vmSeries); - if (vmSeries[0]) { return vmSeries[0].stats[valueOptions.stat]; } diff --git a/public/app/plugins/panel/graph2/GraphPanel.tsx b/public/app/plugins/panel/graph2/GraphPanel.tsx index c859b5f9cf3..f04e73e56fb 100644 --- a/public/app/plugins/panel/graph2/GraphPanel.tsx +++ b/public/app/plugins/panel/graph2/GraphPanel.tsx @@ -21,13 +21,8 @@ export class GraphPanel extends PureComponent { let vmSeries: TimeSeriesVMs; if (data) { - // For now, assume timeseries defaults - const xColumn = 1; // time - const yColumn = 0; // value vmSeries = processTimeSeries({ data, - xColumn, - yColumn, nullValueMode: NullValueMode.Ignore, }); }