public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: replace artisanal FakeDashboardService with generated mock (#49276)

Browse Source 
* chore: replace handmade FakeDashboardService with generated mock

Maintaining a handcrafted FakeDashboardService is not sustainable now that we are in the process of moving the dashboard-related functions out of sqlstore.

* remove dialect global variable
This commit is contained in:
Kristin Laemmert
2022-05-23 11:14:27 -04:00
committed by GitHub
parent ccd160a75e
commit 8c753999df
14 changed files with 639 additions and 274 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/services/dashboards/database/database_test.go
+8 -8
View File
@@ -242,7 +242,7 @@ func TestDashboardDataAccess(t *testing.T) {
SignedInUser: &models.SignedInUser{},
}
err = sqlStore.SearchDashboards(context.Background(), &query)
err = dashboardStore.SearchDashboards(context.Background(), &query)
require.NoError(t, err)
require.Equal(t, len(query.Result), 0)
@@ -315,7 +315,7 @@ func TestDashboardDataAccess(t *testing.T) {
},
}
err := sqlStore.SearchDashboards(context.Background(), &query)
err := dashboardStore.SearchDashboards(context.Background(), &query)
require.NoError(t, err)
require.Equal(t, len(query.Result), 1)
@@ -339,7 +339,7 @@ func TestDashboardDataAccess(t *testing.T) {
},
}
err := sqlStore.SearchDashboards(context.Background(), &query)
err := dashboardStore.SearchDashboards(context.Background(), &query)
require.NoError(t, err)
require.Equal(t, len(query.Result), 1)
@@ -364,7 +364,7 @@ func TestDashboardDataAccess(t *testing.T) {
},
}
err := sqlStore.SearchDashboards(context.Background(), &query)
err := dashboardStore.SearchDashboards(context.Background(), &query)
require.NoError(t, err)
require.Equal(t, len(query.Result), 1)
@@ -386,7 +386,7 @@ func TestDashboardDataAccess(t *testing.T) {
},
}
err := sqlStore.SearchDashboards(context.Background(), &query)
err := dashboardStore.SearchDashboards(context.Background(), &query)
require.NoError(t, err)
require.Equal(t, len(query.Result), 3)
@@ -407,7 +407,7 @@ func TestDashboardDataAccess(t *testing.T) {
},
}
err := sqlStore.SearchDashboards(context.Background(), &query)
err := dashboardStore.SearchDashboards(context.Background(), &query)
require.NoError(t, err)
require.Equal(t, len(query.Result), 2)
@@ -433,7 +433,7 @@ func TestDashboardDataAccess(t *testing.T) {
},
}
err := sqlStore.SearchDashboards(context.Background(), &query)
err := dashboardStore.SearchDashboards(context.Background(), &query)
require.NoError(t, err)
require.Equal(t, len(query.Result), 2)
@@ -471,7 +471,7 @@ func TestDashboardDataAccess(t *testing.T) {
},
IsStarred: true,
}
err = sqlStore.SearchDashboards(context.Background(), &query)
err = dashboardStore.SearchDashboards(context.Background(), &query)
require.NoError(t, err)
require.Equal(t, len(query.Result), 1)