public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change from Apps to "More Apps" (#93454)

Browse Source 
* Change the label used for additional app links from apps to more apps so it doesn't conflict with applications, which is application observability, not the other bucket

* update to more apps

* more in german is mehr

* fix case, update translations correctly

* revert changes to de

* fix be tests

---------

Co-authored-by: joshhunt <josh@trtr.co>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
This commit is contained in:
Tim Levett
2024-10-01 11:31:31 +01:00
committed by GitHub
co-authored by joshhunt Ashley Harrison
parent 95d379368a
commit 8de1047f65
5 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/services/navtree/navtreeimpl/applinks.go
+1 -1
View File
@@ -195,7 +195,7 @@ func (s *ServiceImpl) addPluginToSection(c *contextmodel.ReqContext, treeRoot *n
switch sectionID {
case navtree.NavIDApps:
treeRoot.AddSection(&navtree.NavLink{
Text: "Apps",
Text: "More apps",
Icon: "layer-group",
SubTitle: "App plugins that extend the Grafana experience",
Id: navtree.NavIDApps,
pkg/services/navtree/navtreeimpl/applinks_test.go
+4 -4
View File
@@ -121,14 +121,14 @@ func TestAddAppLinks(t *testing.T) {
},
}
t.Run("Should move apps to Apps category", func(t *testing.T) {
t.Run("Should move apps to 'More apps' category", func(t *testing.T) {
treeRoot := navtree.NavTreeRoot{}
err := service.addAppLinks(&treeRoot, reqCtx)
require.NoError(t, err)
appsNode := treeRoot.FindById(navtree.NavIDApps)
require.NotNil(t, appsNode)
require.Equal(t, "Apps", appsNode.Text)
require.Equal(t, "More apps", appsNode.Text)
require.Len(t, appsNode.Children, 3)
require.Equal(t, testApp1.Name, appsNode.Children[0].Text)
})
@@ -169,7 +169,7 @@ func TestAddAppLinks(t *testing.T) {
require.Len(t, treeRoot.Children, 2)
require.Equal(t, "plugin-page-test-app1", treeRoot.Children[0].Id)
// Check if it is not under the "Apps" section anymore
// Check if it is not under the "More apps" section anymore
appsNode := treeRoot.FindById(navtree.NavIDApps)
require.NotNil(t, appsNode)
require.Len(t, appsNode.Children, 2)
@@ -197,7 +197,7 @@ func TestAddAppLinks(t *testing.T) {
require.Len(t, adminNode.Children, 1)
require.Equal(t, "plugin-page-test-app1", adminNode.Children[0].Id)
// Check if it is not under the "Apps" section anymore
// Check if it is not under the "More apps" section anymore
appsNode := treeRoot.FindById(navtree.NavIDApps)
require.NotNil(t, appsNode)
require.Len(t, appsNode.Children, 2)