From 8e2a780b841d1e47bb8a5b68ce6876c9a24d1c9e Mon Sep 17 00:00:00 2001 From: Will Assis Date: Wed, 14 Jan 2026 19:30:53 -0300 Subject: [PATCH] add descending tests --- .../unified/resource/eventstore_test.go | 50 +++++++++++++------ 1 file changed, 36 insertions(+), 14 deletions(-) diff --git a/pkg/storage/unified/resource/eventstore_test.go b/pkg/storage/unified/resource/eventstore_test.go index 8a6e27d4327..89b7a8c7396 100644 --- a/pkg/storage/unified/resource/eventstore_test.go +++ b/pkg/storage/unified/resource/eventstore_test.go @@ -367,23 +367,45 @@ func testEventStoreListKeysSince(t *testing.T, ctx context.Context, store *event require.NoError(t, err) } - // List events since RV 1500 (should get events with RV 2000 and 3000) - retrievedEvents := make([]string, 0, 2) - for eventKey, err := range store.ListKeysSince(ctx, 1500, SortOrderAsc) { + { + // List events since RV 1500 (should get events with RV 2000 and 3000) + retrievedEvents := make([]string, 0, 2) + for eventKey, err := range store.ListKeysSince(ctx, 1500, SortOrderAsc) { + require.NoError(t, err) + retrievedEvents = append(retrievedEvents, eventKey) + } + + // Should return events in ASCENDING order of resource version + require.Len(t, retrievedEvents, 2) + evt1, err := ParseEventKey(retrievedEvents[0]) require.NoError(t, err) - retrievedEvents = append(retrievedEvents, eventKey) + assert.Equal(t, int64(2000), evt1.ResourceVersion) + assert.Equal(t, "test-2", evt1.Name) + evt2, err := ParseEventKey(retrievedEvents[1]) + require.NoError(t, err) + assert.Equal(t, int64(3000), evt2.ResourceVersion) + assert.Equal(t, "test-3", evt2.Name) } - // Should return events in ascending order of resource version - require.Len(t, retrievedEvents, 2) - evt1, err := ParseEventKey(retrievedEvents[0]) - require.NoError(t, err) - assert.Equal(t, int64(2000), evt1.ResourceVersion) - assert.Equal(t, "test-2", evt1.Name) - evt2, err := ParseEventKey(retrievedEvents[1]) - require.NoError(t, err) - assert.Equal(t, int64(3000), evt2.ResourceVersion) - assert.Equal(t, "test-3", evt2.Name) + { + // List events since RV 1500 (should get events with RV 2000 and 3000) + retrievedEvents := make([]string, 0, 2) + for eventKey, err := range store.ListKeysSince(ctx, 1500, SortOrderDesc) { + require.NoError(t, err) + retrievedEvents = append(retrievedEvents, eventKey) + } + + // Should return events in DESCENDING order of resource version + require.Len(t, retrievedEvents, 2) + evt1, err := ParseEventKey(retrievedEvents[0]) + require.NoError(t, err) + assert.Equal(t, int64(3000), evt1.ResourceVersion) + assert.Equal(t, "test-3", evt1.Name) + evt2, err := ParseEventKey(retrievedEvents[1]) + require.NoError(t, err) + assert.Equal(t, int64(2000), evt2.ResourceVersion) + assert.Equal(t, "test-2", evt2.Name) + } } func TestEventStore_ListSince(t *testing.T) {