From 8e6b8fad01c03f43b63c219fe5a0cabd80a45c1f Mon Sep 17 00:00:00 2001 From: Oscar Kilhed Date: Thu, 24 Apr 2025 14:13:18 +0200 Subject: [PATCH] SchemaV2: Fix saving of transparent setting of vizPanel (#104443) * save transparent setting * make sure we test both transparent and non transparent --- .../__snapshots__/transformSceneToSaveModelSchemaV2.test.ts.snap | 1 + .../serialization/transformSceneToSaveModelSchemaV2.test.ts | 1 - .../serialization/transformSceneToSaveModelSchemaV2.ts | 1 + 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/public/app/features/dashboard-scene/serialization/__snapshots__/transformSceneToSaveModelSchemaV2.test.ts.snap b/public/app/features/dashboard-scene/serialization/__snapshots__/transformSceneToSaveModelSchemaV2.test.ts.snap index db3d9c0644a..c630c36d2e6 100644 --- a/public/app/features/dashboard-scene/serialization/__snapshots__/transformSceneToSaveModelSchemaV2.test.ts.snap +++ b/public/app/features/dashboard-scene/serialization/__snapshots__/transformSceneToSaveModelSchemaV2.test.ts.snap @@ -71,6 +71,7 @@ exports[`transformSceneToSaveModelSchemaV2 should transform scene to save model }, ], "title": "Test Panel", + "transparent": true, "vizConfig": { "kind": "timeseries", "spec": { diff --git a/public/app/features/dashboard-scene/serialization/transformSceneToSaveModelSchemaV2.test.ts b/public/app/features/dashboard-scene/serialization/transformSceneToSaveModelSchemaV2.test.ts index 275a811998d..19a646f64e8 100644 --- a/public/app/features/dashboard-scene/serialization/transformSceneToSaveModelSchemaV2.test.ts +++ b/public/app/features/dashboard-scene/serialization/transformSceneToSaveModelSchemaV2.test.ts @@ -268,7 +268,6 @@ describe('transformSceneToSaveModelSchemaV2', () => { title: 'Test Panel 2', description: 'Test Description 2', fieldConfig: { defaults: {}, overrides: [] }, - displayMode: 'transparent', pluginVersion: '7.0.0', $timeRange: new SceneTimeRange({ timeZone: 'UTC', diff --git a/public/app/features/dashboard-scene/serialization/transformSceneToSaveModelSchemaV2.ts b/public/app/features/dashboard-scene/serialization/transformSceneToSaveModelSchemaV2.ts index a4922c6cf94..426c1f5c7bc 100644 --- a/public/app/features/dashboard-scene/serialization/transformSceneToSaveModelSchemaV2.ts +++ b/public/app/features/dashboard-scene/serialization/transformSceneToSaveModelSchemaV2.ts @@ -220,6 +220,7 @@ export function vizPanelToSchemaV2( title: vizPanel.state.title, description: vizPanel.state.description ?? '', links: getPanelLinks(vizPanel), + transparent: vizPanel.state.displayMode === 'transparent' ? true : undefined, data: { kind: 'QueryGroup', spec: {