From 8f38ef70ceaea12ca27bc0d856951e6e036da115 Mon Sep 17 00:00:00 2001 From: Joao Silva <100691367+JoaoSilvaGrafana@users.noreply.github.com> Date: Fri, 19 Apr 2024 16:28:51 +0100 Subject: [PATCH] Chore: Replace `VerticalGroup` in `OrgDetailsPage` and `BenchmarksPage` (#86621) --- .betterer.results | 6 ------ public/app/features/org/OrgDetailsPage.tsx | 6 +++--- public/app/features/sandbox/BenchmarksPage.tsx | 7 +------ 3 files changed, 4 insertions(+), 15 deletions(-) diff --git a/.betterer.results b/.betterer.results index f03c1e01811..a9a9bb41b7a 100644 --- a/.betterer.results +++ b/.betterer.results @@ -3961,9 +3961,6 @@ exports[`better eslint`] = { "public/app/features/migrate-to-cloud/api/index.ts:5381": [ [0, 0, 0, "Do not use export all (\`export * from ...\`)", "0"] ], - "public/app/features/org/OrgDetailsPage.tsx:5381": [ - [0, 0, 0, "\'VerticalGroup\' import from \'@grafana/ui\' is restricted from being used by a pattern. Use Stack component instead.", "0"] - ], "public/app/features/org/state/actions.ts:5381": [ [0, 0, 0, "Unexpected any. Specify a different type.", "0"] ], @@ -4220,9 +4217,6 @@ exports[`better eslint`] = { [0, 0, 0, "Unexpected any. Specify a different type.", "9"], [0, 0, 0, "Unexpected any. Specify a different type.", "10"] ], - "public/app/features/sandbox/BenchmarksPage.tsx:5381": [ - [0, 0, 0, "\'VerticalGroup\' import from \'@grafana/ui\' is restricted from being used by a pattern. Use Stack component instead.", "0"] - ], "public/app/features/search/page/components/ActionRow.tsx:5381": [ [0, 0, 0, "Styles should be written using objects.", "0"], [0, 0, 0, "Styles should be written using objects.", "1"] diff --git a/public/app/features/org/OrgDetailsPage.tsx b/public/app/features/org/OrgDetailsPage.tsx index 98d181e368f..bcef33f95f9 100644 --- a/public/app/features/org/OrgDetailsPage.tsx +++ b/public/app/features/org/OrgDetailsPage.tsx @@ -1,7 +1,7 @@ import React, { PureComponent } from 'react'; import { ConnectedProps, connect } from 'react-redux'; -import { VerticalGroup } from '@grafana/ui'; +import { Stack } from '@grafana/ui'; import { Page } from 'app/core/components/Page/Page'; import SharedPreferences from 'app/core/components/SharedPreferences/SharedPreferences'; import { appEvents, contextSrv } from 'app/core/core'; @@ -51,7 +51,7 @@ export class OrgDetailsPage extends PureComponent { {!isLoading && ( - + {canReadOrg && } {canReadPreferences && ( { onConfirm={this.handleConfirm} /> )} - + )} diff --git a/public/app/features/sandbox/BenchmarksPage.tsx b/public/app/features/sandbox/BenchmarksPage.tsx index 8a9da1dd877..7be35b46b25 100644 --- a/public/app/features/sandbox/BenchmarksPage.tsx +++ b/public/app/features/sandbox/BenchmarksPage.tsx @@ -1,14 +1,9 @@ import React from 'react'; -import { VerticalGroup } from '@grafana/ui'; import { EmotionPerfTest } from '@grafana/ui/src/components/ThemeDemos/EmotionPerfTest'; export const BenchmarksPage = () => { - return ( - - - - ); + return ; }; export default BenchmarksPage;