From 903d1b77970a08ab3f527b355c60c3388f34c6a6 Mon Sep 17 00:00:00 2001 From: bergquist Date: Tue, 19 Apr 2016 09:13:58 +0200 Subject: [PATCH] tech(cli): dont use defer statements in loops --- pkg/cmd/grafana-cli/commands/install_command.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/cmd/grafana-cli/commands/install_command.go b/pkg/cmd/grafana-cli/commands/install_command.go index 81e7a15233b..b837c1990c1 100644 --- a/pkg/cmd/grafana-cli/commands/install_command.go +++ b/pkg/cmd/grafana-cli/commands/install_command.go @@ -164,14 +164,14 @@ func downloadFile(pluginName, filePath, url string) (err error) { return fmt.Errorf(permissionsDeniedMessage, newFile) } - defer dst.Close() src, err := zf.Open() if err != nil { log.Errorf("%v", err) } - defer src.Close() io.Copy(dst, src) + dst.Close() + src.Close() } }