From 908b248e1066ae441d7a39c0f4c09a819b3510ce Mon Sep 17 00:00:00 2001
From: Ivan Ortega Alba <ivanortegaalba@gmail.com>
Date: Wed, 14 Jun 2023 10:52:49 +0200
Subject: [PATCH] DS Picker: Built-in datasources are not marked as selected
 (#70020)

---
 .../datasources/components/picker/BuiltInDataSourceList.tsx    | 3 ++-
 .../features/datasources/components/picker/DataSourceList.tsx  | 2 +-
 public/app/features/datasources/components/picker/utils.ts     | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/public/app/features/datasources/components/picker/BuiltInDataSourceList.tsx b/public/app/features/datasources/components/picker/BuiltInDataSourceList.tsx
index 1c113403ef5..10f1ea14bcf 100644
--- a/public/app/features/datasources/components/picker/BuiltInDataSourceList.tsx
+++ b/public/app/features/datasources/components/picker/BuiltInDataSourceList.tsx
@@ -6,6 +6,7 @@ import { DataSourceRef } from '@grafana/schema';
 import { useDatasources } from '../../hooks';
 
 import { DataSourceCard } from './DataSourceCard';
+import { isDataSourceMatch } from './utils';
 
 const CUSTOM_DESCRIPTIONS_BY_UID: Record<string, string> = {
   grafana: 'Discover visualizations using mock data',
@@ -30,7 +31,7 @@ export function BuiltInDataSourceList({ className, current, onChange }: BuiltInD
             key={ds.uid}
             ds={ds}
             description={CUSTOM_DESCRIPTIONS_BY_UID[ds.uid]}
-            selected={current === ds.id}
+            selected={isDataSourceMatch(ds, current)}
             onClick={() => onChange(ds)}
           />
         );
diff --git a/public/app/features/datasources/components/picker/DataSourceList.tsx b/public/app/features/datasources/components/picker/DataSourceList.tsx
index a5f317b006c..69efcf57c4f 100644
--- a/public/app/features/datasources/components/picker/DataSourceList.tsx
+++ b/public/app/features/datasources/components/picker/DataSourceList.tsx
@@ -86,7 +86,7 @@ export function DataSourceList(props: DataSourceListProps) {
               pushRecentlyUsedDataSource(ds);
               onChange(ds);
             }}
-            selected={!!isDataSourceMatch(ds, current)}
+            selected={isDataSourceMatch(ds, current)}
             {...(enableKeyboardNavigation ? navigatableProps : {})}
           />
         ))}
diff --git a/public/app/features/datasources/components/picker/utils.ts b/public/app/features/datasources/components/picker/utils.ts
index 96edb7e5de6..16caea27c53 100644
--- a/public/app/features/datasources/components/picker/utils.ts
+++ b/public/app/features/datasources/components/picker/utils.ts
@@ -3,7 +3,7 @@ import { DataSourceInstanceSettings, DataSourceJsonData, DataSourceRef } from '@
 export function isDataSourceMatch(
   ds: DataSourceInstanceSettings | undefined,
   current: string | DataSourceInstanceSettings | DataSourceRef | null | undefined
-): boolean | undefined {
+): boolean {
   if (!ds) {
     return false;
   }