From 9259979278d3be4b2eaef889c348323049de3412 Mon Sep 17 00:00:00 2001 From: Jesse David Peterson Date: Tue, 9 Sep 2025 13:19:41 -0400 Subject: [PATCH] refactor(histogram): don't reach into Grafana's global i18n translations --- packages/grafana-histogram/package.json | 2 ++ packages/grafana-histogram/src/HistogramPanel.tsx | 4 +--- .../src/locales/en-US/grafana-histogram.json | 7 +++++++ .../src/locales/i18next-parser.config.cjs | 12 ++++++++++++ public/locales/en-US/grafana.json | 3 --- 5 files changed, 22 insertions(+), 6 deletions(-) create mode 100644 packages/grafana-histogram/src/locales/en-US/grafana-histogram.json create mode 100644 packages/grafana-histogram/src/locales/i18next-parser.config.cjs diff --git a/packages/grafana-histogram/package.json b/packages/grafana-histogram/package.json index 027475084c3..fef4aa9ea4e 100644 --- a/packages/grafana-histogram/package.json +++ b/packages/grafana-histogram/package.json @@ -26,6 +26,7 @@ }, "files": [ "./dist", + "./src/locales", "./README.md", "./CHANGELOG.md", "./LICENSE_APACHE2" @@ -35,6 +36,7 @@ "bundle": "rollup -c rollup.config.ts --configPlugin esbuild", "clean": "rimraf ./dist ./compiled ./package.tgz", "typecheck": "tsc --emitDeclarationOnly false --noEmit", + "i18n-extract": "i18next --config src/locales/i18next-parser.config.cjs", "prepack": "cp package.json package.json.bak && node ../../scripts/prepare-npm-package.js", "postpack": "mv package.json.bak package.json" }, diff --git a/packages/grafana-histogram/src/HistogramPanel.tsx b/packages/grafana-histogram/src/HistogramPanel.tsx index 28aa8d18b7d..c90d7db8879 100644 --- a/packages/grafana-histogram/src/HistogramPanel.tsx +++ b/packages/grafana-histogram/src/HistogramPanel.tsx @@ -64,9 +64,7 @@ export const HistogramPanel = ({ data, options, fieldConfig, width, height }: Pr return (

- - No histogram found in response - + No histogram found in response

); diff --git a/packages/grafana-histogram/src/locales/en-US/grafana-histogram.json b/packages/grafana-histogram/src/locales/en-US/grafana-histogram.json new file mode 100644 index 00000000000..5579fbac3cf --- /dev/null +++ b/packages/grafana-histogram/src/locales/en-US/grafana-histogram.json @@ -0,0 +1,7 @@ +{ + "grafana-histogram": { + "panel": { + "no-data-message": "No histogram found in response" + } + } +} diff --git a/packages/grafana-histogram/src/locales/i18next-parser.config.cjs b/packages/grafana-histogram/src/locales/i18next-parser.config.cjs new file mode 100644 index 00000000000..9d4cb997cc2 --- /dev/null +++ b/packages/grafana-histogram/src/locales/i18next-parser.config.cjs @@ -0,0 +1,12 @@ +module.exports = { + locales: ['en-US'], // Only en-US is updated - Crowdin will PR with other languages + sort: true, + createOldCatalogs: false, + failOnWarnings: true, + verbose: false, + resetDefaultValueLocale: 'en-US', // Updates extracted values when they change in code + + defaultNamespace: 'grafana-histogram', + input: ['../**/*.{tsx,ts}'], + output: './src/locales/$LOCALE/$NAMESPACE.json', +}; diff --git a/public/locales/en-US/grafana.json b/public/locales/en-US/grafana.json index df049b95433..6ce965e1a14 100644 --- a/public/locales/en-US/grafana.json +++ b/public/locales/en-US/grafana.json @@ -9047,9 +9047,6 @@ }, "histogram": { "category-histogram": "Histogram", - "histogram-panel": { - "no-histogram-found-in-response": "No histogram found in response" - }, "name-fill-opacity": "Fill opacity", "name-gradient-mode": "Gradient mode", "name-line-width": "Line width",