AccessControl: Remove unused error from GetResourcesMetadata (#43710)

* AccessControl: Remove unused error from GetResourcesMetadata

Co-authored-by: J Guerreiro <joao.guerreiro@grafana.com>

pkg/api/datasources.go

@@ -78,12 +78,7 @@ func (hs *HTTPServer) getDataSourceAccessControlMetadata(c *models.ReqContext, d
 	key := fmt.Sprintf("%d", dsID)
 	dsIDs := map[string]bool{key: true}
 
-	metadata, err := accesscontrol.GetResourcesMetadata(c.Req.Context(), userPermissions, "datasources", dsIDs)
-	if err != nil {
-		return nil, err
-	}
-
-	return metadata[key], err
+	return accesscontrol.GetResourcesMetadata(c.Req.Context(), userPermissions, "datasources", dsIDs)[key], nil
 }
 
 func (hs *HTTPServer) GetDataSourceById(c *models.ReqContext) response.Response {

pkg/api/org_users.go

@@ -115,7 +115,7 @@ func (hs *HTTPServer) getUserAccessControlMetadata(c *models.ReqContext, resourc
 		return nil, err
 	}
 
-	return accesscontrol.GetResourcesMetadata(c.Req.Context(), userPermissions, "users", resourceIDs)
+	return accesscontrol.GetResourcesMetadata(c.Req.Context(), userPermissions, "users", resourceIDs), nil
 }
 
 // GET /api/orgs/:orgId/users

pkg/api/user.go

@@ -68,12 +68,7 @@ func (hs *HTTPServer) getGlobalUserAccessControlMetadata(c *models.ReqContext, u
 	key := fmt.Sprintf("%d", userID)
 	userIDs := map[string]bool{key: true}
 
-	metadata, err := accesscontrol.GetResourcesMetadata(c.Req.Context(), userPermissions, "global:users", userIDs)
-	if err != nil {
-		return nil, err
-	}
-
-	return metadata[key], err
+	return accesscontrol.GetResourcesMetadata(c.Req.Context(), userPermissions, "global:users", userIDs)[key], nil
 }
 
 // GET /api/users/lookup