From 92c73036159a9d18c6ff15e35f6c5ac13ff51f38 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Torkel=20=C3=96degaard?= <torkel@grafana.com>
Date: Sat, 23 Feb 2019 13:28:27 +0100
Subject: [PATCH] Refactoring bar gauge

---
 .../src/components/BarGauge/BarGauge.tsx      | 73 +++++++++----------
 .../components/VizRepeater/VizRepeater.tsx    | 61 +++++++++-------
 2 files changed, 70 insertions(+), 64 deletions(-)

diff --git a/packages/grafana-ui/src/components/BarGauge/BarGauge.tsx b/packages/grafana-ui/src/components/BarGauge/BarGauge.tsx
index 59b80d29ac2..17112eb723f 100644
--- a/packages/grafana-ui/src/components/BarGauge/BarGauge.tsx
+++ b/packages/grafana-ui/src/components/BarGauge/BarGauge.tsx
@@ -1,5 +1,5 @@
 // Library
-import React, { PureComponent } from 'react';
+import React, { PureComponent, CSSProperties } from 'react';
 import tinycolor from 'tinycolor2';
 
 // Utils
@@ -65,7 +65,7 @@ export class BarGauge extends PureComponent<Props> {
     };
   }
 
-  getValueStyles(value: string, color: string) {
+  getValueStyles(value: string, color: string): CSSProperties {
     const { width } = this.props;
 
     const guess = width / value.length;
@@ -77,16 +77,28 @@ export class BarGauge extends PureComponent<Props> {
     };
   }
 
-  renderHorizontalBar(valueStyles: React.CSSProperties, valueFormatted: string, barStyles: React.CSSProperties) {
+  renderVerticalBar(valueFormatted: string, valuePercent: number) {
     const { height, width } = this.props;
 
-    const containerStyles = {
+    const maxHeight = width * 0.8;
+    const barHeight = Math.max(valuePercent * maxHeight, 0);
+    const colors = this.getColors();
+    const valueStyles = this.getValueStyles(valueFormatted, colors.value);
+
+    const containerStyles: CSSProperties = {
       width: `${width}px`,
       height: `${height}px`,
       display: 'flex',
       flexDirection: 'column',
       justifyContent: 'flex-end',
-    } as React.CSSProperties;
+    };
+
+    const barStyles: CSSProperties = {
+      height: `${barHeight}px`,
+      width: `${width}px`,
+      backgroundColor: colors.bar,
+      borderTop: `1px solid ${colors.border}`,
+    };
 
     return (
       <div style={containerStyles}>
@@ -98,22 +110,31 @@ export class BarGauge extends PureComponent<Props> {
     );
   }
 
-  renderVerticalBar(valueFormatted: string, barStyles: React.CSSProperties) {
+  renderHorizontalBar(valueFormatted: string, valuePercent: number) {
     const { height, width } = this.props;
-    const colors = this.getColors();
 
-    const containerStyles = {
+    const maxWidth = width - 0.8;
+    const barWidth = Math.max(valuePercent * maxWidth, 0);
+    const colors = this.getColors();
+    const valueStyles = this.getValueStyles(valueFormatted, colors.value);
+
+    valueStyles.marginLeft = '8px';
+
+    const containerStyles: CSSProperties = {
       width: `${width}px`,
       height: `${height}px`,
       display: 'flex',
       flexDirection: 'row',
       alignItems: 'center',
       marginBottom: '8px',
-    } as React.CSSProperties;
+    };
 
-    const valueStyles = this.getValueStyles(valueFormatted, colors.value);
-
-    Object.assign(valueStyles, { marginLeft: '8px' });
+    const barStyles = {
+      height: `${height}px`,
+      width: `${barWidth}px`,
+      backgroundColor: colors.bar,
+      borderRight: `1px solid ${colors.border}`,
+    };
 
     return (
       <div style={containerStyles}>
@@ -126,40 +147,18 @@ export class BarGauge extends PureComponent<Props> {
   }
 
   render() {
-    const { height, width, maxValue, minValue, orientation, unit, decimals } = this.props;
+    const { maxValue, minValue, orientation, unit, decimals } = this.props;
 
     const numericValue = this.getNumericValue();
-    const barMaxHeight = height * 0.8; // 20% for value & name
-    const barMaxWidth = width * 0.8;
     const valuePercent = numericValue / (maxValue - minValue);
-    const barHeight = Math.max(valuePercent * barMaxHeight, 0);
-    const barWidth = Math.max(valuePercent * barMaxWidth, 0);
 
     const formatFunc = getValueFormat(unit);
     const valueFormatted = formatFunc(numericValue, decimals);
-    const colors = this.getColors();
-    const valueStyles = this.getValueStyles(valueFormatted, colors.value);
     const vertical = orientation === 'vertical';
 
-    const horizontalBarStyles = {
-      height: `${barHeight}px`,
-      width: `${width}px`,
-      backgroundColor: colors.bar,
-      borderTop: `1px solid ${colors.border}`,
-    };
-
-    const verticalBarStyles = {
-      height: `${height}px`,
-      width: `${barWidth}px`,
-      backgroundColor: colors.bar,
-      borderRight: `1px solid ${colors.border}`,
-    };
-
-    const barStyles = vertical ? verticalBarStyles : horizontalBarStyles;
-
     return vertical
-      ? this.renderVerticalBar(valueFormatted, barStyles)
-      : this.renderHorizontalBar(valueStyles, valueFormatted, barStyles);
+      ? this.renderVerticalBar(valueFormatted, valuePercent)
+      : this.renderHorizontalBar(valueFormatted, valuePercent);
   }
 }
 
diff --git a/packages/grafana-ui/src/components/VizRepeater/VizRepeater.tsx b/packages/grafana-ui/src/components/VizRepeater/VizRepeater.tsx
index f6561cede26..276bfa3517e 100644
--- a/packages/grafana-ui/src/components/VizRepeater/VizRepeater.tsx
+++ b/packages/grafana-ui/src/components/VizRepeater/VizRepeater.tsx
@@ -15,51 +15,58 @@ interface Props {
   orientation?: string;
 }
 
+const SPACE_BETWEEN = 10;
+
 export class VizRepeater extends PureComponent<Props> {
+  getOrientation() {
+    const { orientation, width, height } = this.props;
+
+    if (!orientation) {
+      if (width > height) {
+        return 'horizontal';
+      } else {
+        return 'vertical';
+      }
+    }
+
+    return orientation;
+  }
+
   render() {
-    const { children, orientation, height, values, width } = this.props;
+    const { children, height, values, width } = this.props;
+    const orientation = this.getOrientation();
 
-    const vizContainerWidth = (1 / values.length) * 100;
-    const vizContainerHeight = (1 / values.length) * 100;
-    const repeatingVizWidth = Math.floor(width / values.length) - 10; // make Gauge slightly smaller than panel.
-    const repeatingVizHeight = Math.floor(height / values.length) - 10;
-
-    const horizontalVisualization = {
+    const itemStyles: React.CSSProperties = {
       display: 'flex',
-      height: height,
-      width: `${vizContainerWidth}%`,
     };
 
-    const verticalVisualization = {
+    const repeaterStyle: React.CSSProperties = {
       display: 'flex',
-      width: width,
-      height: `${vizContainerHeight}%`,
     };
 
-    const repeaterStyle = {
-      display: 'flex',
-      flexDirection: orientation === 'vertical' || height > width ? 'column' : 'row',
-    } as React.CSSProperties;
-
-    let vizContainerStyle = {};
-    let vizWidth = width;
     let vizHeight = height;
+    let vizWidth = width;
 
-    if ((orientation && orientation === 'horizontal') || width > height) {
-      vizContainerStyle = horizontalVisualization;
-      vizWidth = repeatingVizWidth;
+    if (orientation === 'horizontal') {
+      repeaterStyle.flexDirection = 'column';
+      itemStyles.margin = `${SPACE_BETWEEN / 2}px 0`;
+      vizWidth = width;
+      vizHeight = height / values.length - SPACE_BETWEEN;
+    } else {
+      repeaterStyle.flexDirection = 'row';
+      itemStyles.margin = `0 ${SPACE_BETWEEN / 2}px`;
+      vizHeight = height;
+      vizWidth = width / values.length - SPACE_BETWEEN;
     }
 
-    if ((orientation && orientation === 'vertical') || height > width) {
-      vizContainerStyle = verticalVisualization;
-      vizHeight = repeatingVizHeight;
-    }
+    itemStyles.width = `${vizWidth}px`;
+    itemStyles.height = `${vizHeight}px`;
 
     return (
       <div style={repeaterStyle}>
         {values.map((valueInfo, index) => {
           return (
-            <div key={index} style={vizContainerStyle}>
+            <div key={index} style={itemStyles}>
               {children({ vizHeight, vizWidth, valueInfo })}
             </div>
           );