diff --git a/public/app/core/components/AppChrome/AppChrome.tsx b/public/app/core/components/AppChrome/AppChrome.tsx
index b47c655188b..e4bd8b80903 100644
--- a/public/app/core/components/AppChrome/AppChrome.tsx
+++ b/public/app/core/components/AppChrome/AppChrome.tsx
@@ -82,7 +82,7 @@ export function AppChrome({ children }: Props) {
Skip to main content
-
+
+
>
)}
-
+
{!state.chromeless && state.megaMenuDocked && state.megaMenuOpen && (
chrome.setMegaMenuOpen(false)} />
)}
-
+
{children}
-
+
-
+
{!state.chromeless && !state.megaMenuDocked && }
{!state.chromeless && }
{shouldShowReturnToPrevious && state.returnToPrevious && (
diff --git a/public/app/features/dashboard/components/SubMenu/SubMenu.tsx b/public/app/features/dashboard/components/SubMenu/SubMenu.tsx
index 16a5742e9d4..85e77fc787a 100644
--- a/public/app/features/dashboard/components/SubMenu/SubMenu.tsx
+++ b/public/app/features/dashboard/components/SubMenu/SubMenu.tsx
@@ -51,10 +51,6 @@ class SubMenuUnConnected extends PureComponent {
const styles = getStyles(theme);
- if (!dashboard.isSubMenuVisible()) {
- return null;
- }
-
const readOnlyVariables = dashboard.meta.isSnapshot ?? false;
return (
diff --git a/public/app/features/dashboard/containers/DashboardPage.test.tsx b/public/app/features/dashboard/containers/DashboardPage.test.tsx
index 24486c53e2a..004f1d951aa 100644
--- a/public/app/features/dashboard/containers/DashboardPage.test.tsx
+++ b/public/app/features/dashboard/containers/DashboardPage.test.tsx
@@ -306,10 +306,12 @@ describe('DashboardPage', () => {
});
describe('No kiosk mode tv', () => {
- it('should render dashboard page toolbar and submenu', async () => {
- setup({ dashboard: getTestDashboard() });
+ it('should render dashboard page toolbar with no submenu', async () => {
+ setup({
+ dashboard: getTestDashboard(),
+ });
expect(await screen.findAllByTestId(selectors.pages.Dashboard.DashNav.navV2)).toHaveLength(1);
- expect(screen.getAllByLabelText(selectors.pages.Dashboard.SubMenu.submenu)).toHaveLength(1);
+ expect(screen.queryAllByLabelText(selectors.pages.Dashboard.SubMenu.submenu)).toHaveLength(0);
});
});
diff --git a/public/app/features/dashboard/containers/DashboardPage.tsx b/public/app/features/dashboard/containers/DashboardPage.tsx
index 71d44e4e993..188c10d9d46 100644
--- a/public/app/features/dashboard/containers/DashboardPage.tsx
+++ b/public/app/features/dashboard/containers/DashboardPage.tsx
@@ -302,7 +302,7 @@ export class UnthemedDashboardPage extends PureComponent {
}
const inspectPanel = this.getInspectPanel();
- const showSubMenu = !editPanel && !kioskMode && !this.props.queryParams.editview;
+ const showSubMenu = !editPanel && !kioskMode && !this.props.queryParams.editview && dashboard.isSubMenuVisible();
const showToolbar = kioskMode !== KioskMode.Full && !queryParams.editview;
diff --git a/public/app/plugins/panel/news/component/News.tsx b/public/app/plugins/panel/news/component/News.tsx
index 39c95ff82d1..c47f1d1ade7 100644
--- a/public/app/plugins/panel/news/component/News.tsx
+++ b/public/app/plugins/panel/news/component/News.tsx
@@ -19,9 +19,10 @@ function NewsComponent({ width, showImage, data, index }: NewsItemProps) {
const styles = useStyles2(getStyles);
const useWideLayout = width > 600;
const newsItem = data.get(index);
+ const titleId = encodeURI(newsItem.title);
return (
-
+
{showImage && newsItem.ogImage && (
- {newsItem.title}
+
+ {newsItem.title}
+