From 96127dce6211ee99c9c3a254c23134d9473c2255 Mon Sep 17 00:00:00 2001 From: George Robinson Date: Fri, 1 Mar 2024 17:17:55 +0000 Subject: [PATCH] Alerting: Fix bug in screenshot service using incorrect limit (#83786) This commit fixes a bug in the screenshot service where [alerting].concurrent_render_limit was used instead of [rendering].concurrent_render_request_limit, as in the docs. --- pkg/services/screenshot/screenshot.go | 2 +- pkg/services/screenshot/screenshot_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/services/screenshot/screenshot.go b/pkg/services/screenshot/screenshot.go index 7f351184c8c..47e29fdccdb 100644 --- a/pkg/services/screenshot/screenshot.go +++ b/pkg/services/screenshot/screenshot.go @@ -122,7 +122,7 @@ func (s *HeadlessScreenshotService) Take(ctx context.Context, opts ScreenshotOpt Width: opts.Width, Height: opts.Height, Theme: opts.Theme, - ConcurrentLimit: s.cfg.AlertingRenderLimit, + ConcurrentLimit: s.cfg.RendererConcurrentRequestLimit, Path: u.String(), } diff --git a/pkg/services/screenshot/screenshot_test.go b/pkg/services/screenshot/screenshot_test.go index d1c665dffa6..392c45482e5 100644 --- a/pkg/services/screenshot/screenshot_test.go +++ b/pkg/services/screenshot/screenshot_test.go @@ -54,7 +54,7 @@ func TestHeadlessScreenshotService(t *testing.T) { Height: DefaultHeight, Theme: DefaultTheme, Path: "d-solo/foo/bar?from=now-6h&orgId=2&panelId=4&to=now-2h", - ConcurrentLimit: cfg.AlertingRenderLimit, + ConcurrentLimit: cfg.RendererConcurrentRequestLimit, } opts.From = "now-6h"