From 961c31a7478564f48636ed4b7faf70bb4107d2e4 Mon Sep 17 00:00:00 2001 From: bergquist Date: Fri, 3 Jun 2016 15:06:54 +0200 Subject: [PATCH] test(util): add unit test for string util --- pkg/util/strings.go | 6 +++--- pkg/util/strings_test.go | 15 +++++++++++++++ 2 files changed, 18 insertions(+), 3 deletions(-) create mode 100644 pkg/util/strings_test.go diff --git a/pkg/util/strings.go b/pkg/util/strings.go index f0ac3403296..8598949c2cb 100644 --- a/pkg/util/strings.go +++ b/pkg/util/strings.go @@ -10,9 +10,9 @@ func StringsFallback3(val1 string, val2 string, val3 string) string { func stringsFallback(vals ...string) string { for _, v := range vals { - if v != "" { - return v - } + if v != "" { + return v + } } return "" } diff --git a/pkg/util/strings_test.go b/pkg/util/strings_test.go new file mode 100644 index 00000000000..c959dfd1d54 --- /dev/null +++ b/pkg/util/strings_test.go @@ -0,0 +1,15 @@ +package util + +import ( + "testing" + + . "github.com/smartystreets/goconvey/convey" +) + +func TestStringsUtil(t *testing.T) { + Convey("Falling back until none empty string", t, func() { + So(StringsFallback2("1", "2"), ShouldEqual, "1") + So(StringsFallback2("", "2"), ShouldEqual, "2") + So(StringsFallback3("", "", "3"), ShouldEqual, "3") + }) +}