From 962340bcd1adce74412cf57e04e920efa761b00f Mon Sep 17 00:00:00 2001 From: Tobias Skarhed Date: Tue, 3 Jul 2018 13:26:42 +0200 Subject: [PATCH] Create new instance in beforeEach --- .../datasource/mysql/specs/datasource.jest.ts | 16 +++++++++------- .../datasource/postgres/specs/datasource.jest.ts | 15 +++++++++------ 2 files changed, 18 insertions(+), 13 deletions(-) diff --git a/public/app/plugins/datasource/mysql/specs/datasource.jest.ts b/public/app/plugins/datasource/mysql/specs/datasource.jest.ts index 5a5881b3165..5a97e4b441d 100644 --- a/public/app/plugins/datasource/mysql/specs/datasource.jest.ts +++ b/public/app/plugins/datasource/mysql/specs/datasource.jest.ts @@ -5,15 +5,17 @@ import { MysqlDatasource } from '../datasource'; import { CustomVariable } from 'app/features/templating/custom_variable'; describe('MySQLDatasource', function() { - let instanceSettings = { name: 'mysql' }; let backendSrv = {}; let templateSrv = new TemplateSrvStub(); let ctx = { - ds: new MysqlDatasource(instanceSettings, backendSrv, {}, templateSrv), - backendSrv + backendSrv, }; + beforeEach(() => { + ctx.ds = new MysqlDatasource(instanceSettings, backendSrv, {}, templateSrv); + }); + describe('When performing annotationQuery', function() { let results; @@ -49,7 +51,7 @@ describe('MySQLDatasource', function() { }; beforeEach(function() { - ctx.backendSrv.datasourceRequest = jest.fn((options) => { + ctx.backendSrv.datasourceRequest = jest.fn(options => { return Promise.resolve({ data: response, status: 200 }); }); ctx.ds.annotationQuery(options).then(function(data) { @@ -92,7 +94,7 @@ describe('MySQLDatasource', function() { }; beforeEach(function() { - ctx.backendSrv.datasourceRequest = jest.fn((options) => { + ctx.backendSrv.datasourceRequest = jest.fn(options => { return Promise.resolve({ data: response, status: 200 }); }); ctx.ds.metricFindQuery(query).then(function(data) { @@ -128,7 +130,7 @@ describe('MySQLDatasource', function() { }; beforeEach(function() { - ctx.backendSrv.datasourceRequest = jest.fn((options) => { + ctx.backendSrv.datasourceRequest = jest.fn(options => { return Promise.resolve({ data: response, status: 200 }); }); ctx.ds.metricFindQuery(query).then(function(data) { @@ -166,7 +168,7 @@ describe('MySQLDatasource', function() { }; beforeEach(function() { - ctx.backendSrv.datasourceRequest = jest.fn((options) => { + ctx.backendSrv.datasourceRequest = jest.fn(options => { return Promise.resolve({ data: response, status: 200 }); }); ctx.ds.metricFindQuery(query).then(function(data) { diff --git a/public/app/plugins/datasource/postgres/specs/datasource.jest.ts b/public/app/plugins/datasource/postgres/specs/datasource.jest.ts index d00e036a514..87e4c348379 100644 --- a/public/app/plugins/datasource/postgres/specs/datasource.jest.ts +++ b/public/app/plugins/datasource/postgres/specs/datasource.jest.ts @@ -9,10 +9,13 @@ describe('PostgreSQLDatasource', function() { let backendSrv = {}; let templateSrv = new TemplateSrvStub(); let ctx = { - ds: new PostgresDatasource(instanceSettings, backendSrv, {}, templateSrv), - backendSrv + backendSrv, }; + beforeEach(() => { + ctx.ds = new PostgresDatasource(instanceSettings, backendSrv, {}, templateSrv); + }); + describe('When performing annotationQuery', function() { let results; @@ -48,7 +51,7 @@ describe('PostgreSQLDatasource', function() { }; beforeEach(function() { - ctx.backendSrv.datasourceRequest = jest.fn((options) => { + ctx.backendSrv.datasourceRequest = jest.fn(options => { return Promise.resolve({ data: response, status: 200 }); }); ctx.ds.annotationQuery(options).then(function(data) { @@ -91,7 +94,7 @@ describe('PostgreSQLDatasource', function() { }; beforeEach(function() { - ctx.backendSrv.datasourceRequest = jest.fn((options) => { + ctx.backendSrv.datasourceRequest = jest.fn(options => { return Promise.resolve({ data: response, status: 200 }); }); ctx.ds.metricFindQuery(query).then(function(data) { @@ -127,7 +130,7 @@ describe('PostgreSQLDatasource', function() { }; beforeEach(function() { - ctx.backendSrv.datasourceRequest = jest.fn((options) => { + ctx.backendSrv.datasourceRequest = jest.fn(options => { return Promise.resolve({ data: response, status: 200 }); }); ctx.ds.metricFindQuery(query).then(function(data) { @@ -165,7 +168,7 @@ describe('PostgreSQLDatasource', function() { }; beforeEach(() => { - ctx.backendSrv.datasourceRequest = jest.fn((options) => { + ctx.backendSrv.datasourceRequest = jest.fn(options => { return Promise.resolve({ data: response, status: 200 }); }); ctx.ds.metricFindQuery(query).then(function(data) {